Skip to content

Turning off default features of regex #1622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
est31 opened this issue Sep 19, 2019 · 4 comments
Closed

Turning off default features of regex #1622

est31 opened this issue Sep 19, 2019 · 4 comments
Labels
enhancement help wanted

Comments

@est31
Copy link
Member

est31 commented Sep 19, 2019

It would be cool, from a dependency reduction POV, to turn off some of the default features of regex, at least the performance one. IDK about the unicode feature.
@emilio
Copy link
Contributor

emilio commented Sep 20, 2019

Sounds fair. Wanna submit a patch?

@est31
Copy link
Member Author

est31 commented Sep 20, 2019

Wanna submit a patch

Thanks but I'll pass. I'd prefer someone else to submit it. It's quite trivial anyway.

@emilio
Copy link
Contributor

emilio commented Sep 20, 2019

Sure, I can do that if I remember, I'm away from my laptop atm. Thanks for filing!

@PyroLagus PyroLagus mentioned this issue Oct 9, 2019
Merged
@Lokathor Lokathor mentioned this issue Oct 11, 2019
Closed
@kulp
Copy link
Member

kulp commented Jun 2, 2022

This was closed by #1643 but without the Github auto-resolution magic words.

@kulp kulp closed this as completed Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kulp @emilio @est31