Auto merge of #1436 - sanxiyn:canonical-path, r=emilio

Use canonical path for type alias loop detection

Fix #1435

Author: bors-servo

src/codegen/mod.rs

@@ -666,6 +666,7 @@ impl CodeGenerator for Type {
                     .through_type_refs()
                     .resolve(ctx);
                 let name = item.canonical_name(ctx);
+                let path = item.canonical_path(ctx);
 
                 {
                     let through_type_aliases = inner.into_resolver()
@@ -678,7 +679,7 @@ impl CodeGenerator for Type {
                     // typedef struct foo { ... } foo;
                     //
                     // here, and also other more complex cases like #946.
-                    if through_type_aliases.canonical_name(ctx) == name {
+                    if through_type_aliases.canonical_path(ctx) == path {
                         return;
                     }
                 }

tests/expectations/tests/issue-1435.rs

@@ -0,0 +1,26 @@
+/* automatically generated by rust-bindgen */
+
+#![allow(
+    dead_code,
+    non_snake_case,
+    non_camel_case_types,
+    non_upper_case_globals
+)]
+
+#[allow(non_snake_case, non_camel_case_types, non_upper_case_globals)]
+pub mod root {
+    #[allow(unused_imports)]
+    use self::super::root;
+    pub mod ns {
+        #[allow(unused_imports)]
+        use self::super::super::root;
+        pub const AB_A: root::ns::AB = 0;
+        pub const AB_B: root::ns::AB = 1;
+        pub type AB = i32;
+    }
+    pub use self::super::root::ns::AB;
+    extern "C" {
+        #[link_name = "\u{1}_ZL2kA"]
+        pub static kA: root::AB;
+    }
+}

tests/headers/issue-1435.hpp

@@ -0,0 +1,7 @@
+// bindgen-flags: --enable-cxx-namespaces
+
+namespace ns {
+enum class AB { A, B };
+}
+using AB = ns::AB;
+static const AB kA = AB::A;