Skip to content

Commit c769d52

Browse files
committed
chore: remove completed TODO comments
1 parent 98a4881 commit c769d52

File tree

1 file changed

+3
-15
lines changed

1 file changed

+3
-15
lines changed

bindgen/codegen/mod.rs

+3-15
Original file line numberDiff line numberDiff line change
@@ -707,8 +707,7 @@ impl CodeGenerator for Var {
707707
cb.process_attributes(
708708
&AttributeInfo {
709709
name: &canonical_name,
710-
// TODO: Change to Var
711-
kind: AttributeItemKind::Struct,
710+
kind: AttributeItemKind::Var,
712711
},
713712
&mut attrs,
714713
);
@@ -834,8 +833,7 @@ impl CodeGenerator for Var {
834833
cb.process_attributes(
835834
&AttributeInfo {
836835
name: &canonical_name,
837-
// TODO: Change to Var
838-
kind: AttributeItemKind::Struct,
836+
kind: AttributeItemKind::Var,
839837
},
840838
&mut attrs,
841839
);
@@ -2873,7 +2871,6 @@ impl CodeGenerator for CompInfo {
28732871
// non-zero padding bytes, especially when forwards/backwards compatibility is
28742872
// involved.
28752873
result.push(quote! {
2876-
// TODO: Only apply attributes relevant to conditional compilation
28772874
#( #attrs )*
28782875
impl #impl_generics_labels Default for #ty_for_impl {
28792876
fn default() -> Self {
@@ -2894,7 +2891,6 @@ impl CodeGenerator for CompInfo {
28942891
let prefix = ctx.trait_prefix();
28952892

28962893
result.push(quote! {
2897-
// TODO: Only apply attributes relevant to conditional compilation
28982894
#( #attrs )*
28992895
impl #impl_generics_labels ::#prefix::fmt::Debug for #ty_for_impl {
29002896
#impl_
@@ -2920,7 +2916,6 @@ impl CodeGenerator for CompInfo {
29202916

29212917
let prefix = ctx.trait_prefix();
29222918
result.push(quote! {
2923-
// TODO: Only apply attributes relevant to conditional compilation
29242919
#( #attrs )*
29252920
impl #impl_generics_labels ::#prefix::cmp::PartialEq for #ty_for_impl #partialeq_bounds {
29262921
#impl_
@@ -2931,7 +2926,6 @@ impl CodeGenerator for CompInfo {
29312926

29322927
if !methods.is_empty() {
29332928
result.push(quote! {
2934-
// TODO: Only apply attributes relevant to conditional compilation
29352929
#( #attrs )*
29362930
impl #impl_generics_labels #ty_for_impl {
29372931
#( #methods )*
@@ -3415,10 +3409,6 @@ impl<'a> EnumBuilder<'a> {
34153409
is_global,
34163410
} => EnumBuilder::NewType {
34173411
canonical_name: name,
3418-
// TODO: Think this through in the morning, `attrs` get injected into tokens here already for NewTypes
3419-
// TODO: That obviously changes some things, might actually save a lot of work :)
3420-
// TODO: Also check the other variants
3421-
// TODO: Insert #[doc = "meow"] to test
34223412
tokens: quote! {
34233413
#( #attrs )*
34243414
pub struct #ident (pub #repr);
@@ -3528,7 +3518,7 @@ impl<'a> EnumBuilder<'a> {
35283518
let enum_ident = ctx.rust_ident(canonical_name);
35293519
let variant_ident = ctx.rust_ident(variant_name);
35303520

3531-
// TODO: Make sure attributes are applied properly here, waiting for CI failure
3521+
// FIXME: Make sure attributes are emitted properly
35323522
result.push(quote! {
35333523
impl #enum_ident {
35343524
#doc
@@ -3945,9 +3935,7 @@ impl CodeGenerator for Enum {
39453935
let enum_canonical_name = &ident;
39463936
let variant_name =
39473937
ctx.rust_ident_raw(&*mangled_name);
3948-
// TODO: Check if we need the attributes here
39493938
result.push(quote! {
3950-
// TODO: Only apply attributes relevant to conditional compilation
39513939
#(#attrs)*
39523940
impl #enum_rust_ty {
39533941
pub const #variant_name : #enum_rust_ty =

0 commit comments

Comments
 (0)