@@ -707,8 +707,7 @@ impl CodeGenerator for Var {
707
707
cb. process_attributes (
708
708
& AttributeInfo {
709
709
name : & canonical_name,
710
- // TODO: Change to Var
711
- kind : AttributeItemKind :: Struct ,
710
+ kind : AttributeItemKind :: Var ,
712
711
} ,
713
712
& mut attrs,
714
713
) ;
@@ -834,8 +833,7 @@ impl CodeGenerator for Var {
834
833
cb. process_attributes (
835
834
& AttributeInfo {
836
835
name : & canonical_name,
837
- // TODO: Change to Var
838
- kind : AttributeItemKind :: Struct ,
836
+ kind : AttributeItemKind :: Var ,
839
837
} ,
840
838
& mut attrs,
841
839
) ;
@@ -2873,7 +2871,6 @@ impl CodeGenerator for CompInfo {
2873
2871
// non-zero padding bytes, especially when forwards/backwards compatibility is
2874
2872
// involved.
2875
2873
result. push ( quote ! {
2876
- // TODO: Only apply attributes relevant to conditional compilation
2877
2874
#( #attrs ) *
2878
2875
impl #impl_generics_labels Default for #ty_for_impl {
2879
2876
fn default ( ) -> Self {
@@ -2894,7 +2891,6 @@ impl CodeGenerator for CompInfo {
2894
2891
let prefix = ctx. trait_prefix ( ) ;
2895
2892
2896
2893
result. push ( quote ! {
2897
- // TODO: Only apply attributes relevant to conditional compilation
2898
2894
#( #attrs ) *
2899
2895
impl #impl_generics_labels :: #prefix:: fmt:: Debug for #ty_for_impl {
2900
2896
#impl_
@@ -2920,7 +2916,6 @@ impl CodeGenerator for CompInfo {
2920
2916
2921
2917
let prefix = ctx. trait_prefix ( ) ;
2922
2918
result. push ( quote ! {
2923
- // TODO: Only apply attributes relevant to conditional compilation
2924
2919
#( #attrs ) *
2925
2920
impl #impl_generics_labels :: #prefix:: cmp:: PartialEq for #ty_for_impl #partialeq_bounds {
2926
2921
#impl_
@@ -2931,7 +2926,6 @@ impl CodeGenerator for CompInfo {
2931
2926
2932
2927
if !methods. is_empty ( ) {
2933
2928
result. push ( quote ! {
2934
- // TODO: Only apply attributes relevant to conditional compilation
2935
2929
#( #attrs ) *
2936
2930
impl #impl_generics_labels #ty_for_impl {
2937
2931
#( #methods ) *
@@ -3415,10 +3409,6 @@ impl<'a> EnumBuilder<'a> {
3415
3409
is_global,
3416
3410
} => EnumBuilder :: NewType {
3417
3411
canonical_name : name,
3418
- // TODO: Think this through in the morning, `attrs` get injected into tokens here already for NewTypes
3419
- // TODO: That obviously changes some things, might actually save a lot of work :)
3420
- // TODO: Also check the other variants
3421
- // TODO: Insert #[doc = "meow"] to test
3422
3412
tokens : quote ! {
3423
3413
#( #attrs ) *
3424
3414
pub struct #ident ( pub #repr) ;
@@ -3528,7 +3518,7 @@ impl<'a> EnumBuilder<'a> {
3528
3518
let enum_ident = ctx. rust_ident ( canonical_name) ;
3529
3519
let variant_ident = ctx. rust_ident ( variant_name) ;
3530
3520
3531
- // TODO : Make sure attributes are applied properly here, waiting for CI failure
3521
+ // FIXME : Make sure attributes are emitted properly
3532
3522
result. push ( quote ! {
3533
3523
impl #enum_ident {
3534
3524
#doc
@@ -3945,9 +3935,7 @@ impl CodeGenerator for Enum {
3945
3935
let enum_canonical_name = & ident;
3946
3936
let variant_name =
3947
3937
ctx. rust_ident_raw ( & * mangled_name) ;
3948
- // TODO: Check if we need the attributes here
3949
3938
result. push ( quote ! {
3950
- // TODO: Only apply attributes relevant to conditional compilation
3951
3939
#( #attrs) *
3952
3940
impl #enum_rust_ty {
3953
3941
pub const #variant_name : #enum_rust_ty =
0 commit comments