avoid implicit Cargo features

Author: tshepang

CHANGELOG.md

@@ -190,6 +190,12 @@
   feature when depending on `bindgen` as a library.
 * Items are now parsed in the order they appear in source files. This may result in
   auto-generated `_bindgen_*` names having a different index.
+* Remove redundant Cargo features, which were all implicit:
+  - bindgen-cli: `env_logger` and `log` removed in favor of `logging`
+  - bindgen (lib):
+    + `log` removed in favor of `logging`
+    + `which` removed in favor of `which-logging`
+    + `annotate-snippets` removed in favor of `experimental`
 
 ## Removed
 

bindgen-cli/Cargo.toml

@@ -29,7 +29,7 @@ log = { version = "0.4", optional = true }
 
 [features]
 default = ["logging", "runtime", "which-rustfmt"]
-logging = ["bindgen/logging", "env_logger", "log"]
+logging = ["bindgen/logging", "dep:env_logger", "dep:log"]
 static = ["bindgen/static"]
 runtime = ["bindgen/runtime"]
 # Dynamically discover a `rustfmt` binary using the `which` crate

bindgen/Cargo.toml

@@ -44,12 +44,12 @@ log = { version = "0.4", optional = true }
 
 [features]
 default = ["logging", "prettyplease", "runtime", "which-rustfmt"]
-logging = ["log"]
+logging = ["dep:log"]
 static = ["clang-sys/static"]
 runtime = ["clang-sys/runtime"]
 # Dynamically discover a `rustfmt` binary using the `which` crate
-which-rustfmt = ["which"]
-experimental = ["annotate-snippets"]
+which-rustfmt = ["dep:which"]
+experimental = ["dep:annotate-snippets"]
 
 ## The following features are for internal use and they shouldn't be used if
 ## you're not hacking on bindgen