Make TargetInfo::new infallible

It is not clear why this interface was fallible previously anyway.

Author: kulp

src/clang.rs

@@ -2026,7 +2026,7 @@ pub struct TargetInfo {
 
 impl TargetInfo {
     /// Tries to obtain target information from libclang.
-    pub fn new(tu: &TranslationUnit) -> Option<Self> {
+    pub fn new(tu: &TranslationUnit) -> Self {
         let triple;
         let pointer_width;
         unsafe {
@@ -2037,9 +2037,9 @@ impl TargetInfo {
         }
         assert!(pointer_width > 0);
         assert_eq!(pointer_width % 8, 0);
-        Some(TargetInfo {
+        TargetInfo {
             triple,
             pointer_width: pointer_width as usize,
-        })
+        }
     }
 }

src/ir/context.rs

@@ -368,7 +368,7 @@ pub struct BindgenContext {
     translation_unit: clang::TranslationUnit,
 
     /// Target information that can be useful for some stuff.
-    target_info: Option<clang::TargetInfo>,
+    target_info: clang::TargetInfo,
 
     /// The options given by the user via cli or other medium.
     options: BindgenOptions,
@@ -583,16 +583,14 @@ If you encounter an error missing from this list, please file an issue or a PR!"
 
         #[cfg(debug_assertions)]
         {
-            if let Some(ref ti) = target_info {
-                if effective_target == HOST_TARGET {
-                    assert_eq!(
-                        ti.pointer_width / 8,
-                        mem::size_of::<*mut ()>(),
-                        "{:?} {:?}",
-                        effective_target,
-                        HOST_TARGET
-                    );
-                }
+            if effective_target == HOST_TARGET {
+                assert_eq!(
+                    target_info.pointer_width / 8,
+                    mem::size_of::<*mut ()>(),
+                    "{:?} {:?}",
+                    effective_target,
+                    HOST_TARGET
+                );
             }
         }
 
@@ -645,10 +643,7 @@ If you encounter an error missing from this list, please file an issue or a PR!"
     /// Returns the pointer width to use for the target for the current
     /// translation.
     pub fn target_pointer_size(&self) -> usize {
-        if let Some(ref ti) = self.target_info {
-            return ti.pointer_width / 8;
-        }
-        mem::size_of::<*mut ()>()
+        return self.target_info.pointer_width / 8;
     }
 
     /// Get the stack of partially parsed types that we are in the middle of