issue 1723 [WIP] rebased. Took a step backwards to something that compiles. Have commented away the Builder::generate_options() that causes errors. Lets go from here

Author: smurfd

src/lib.rs

@@ -1336,7 +1336,7 @@ impl Builder {
     }
 
     /// Generate the Rust bindings options
-    pub fn generate_options(&mut self) -> &mut Self {
+    pub fn generate_options(mut self) -> Self {
         // Add any extra arguments from the environment to the clang command line.
         if let Some(extra_clang_args) =
             env::var("BINDGEN_EXTRA_CLANG_ARGS").ok()
@@ -1366,9 +1366,10 @@ impl Builder {
         );
         self
     }
+
     /// Generate the Rust bindings using the options built up thus far.
-    pub fn generate(mut self) -> Result<Bindings, ()> {
-        Bindings::generate(&Builder::generate_options(&mut self).options)
+    pub fn generate(self) -> Result<Bindings, ()> {
+        Bindings::generate(Builder::generate_options(self).options)
     }
 
     /// Preprocess and dump the input header files to disk.
@@ -1384,7 +1385,7 @@ impl Builder {
                     "Cannot find clang executable",
                 )
             })?;
-        Builder::generate_options(self);
+        // Builder::generate_options(self);
         // The contents of a wrapper file that includes all the input header
         // files.
         let mut wrapper_contents = String::new();
@@ -2097,7 +2098,7 @@ impl Bindings {
 
     /// Generate bindings for the given options.
     pub(crate) fn generate(
-        mut options: &BindgenOptions,
+        mut options: BindgenOptions,
     ) -> Result<Bindings, ()> {
         ensure_libclang_is_loaded();