ir: Ignore constructors with bogus spellings.

Author: emilio

src/ir/function.rs

@@ -347,13 +347,22 @@ impl FunctionSig {
             return Err(ParseError::Continue);
         }
 
+        let kind = cursor.kind();
+
+        // Constructors of non-type template parameter classes for some reason
+        // include the template parameter in their name. Just skip them, since
+        // we don't handle well non-type template parameters anyway.
+        if kind == CXCursor_Constructor && spelling.contains('<') {
+            return Err(ParseError::Continue);
+        }
+
         let cursor = if cursor.is_valid() {
             *cursor
         } else {
             ty.declaration()
         };
 
-        let mut args: Vec<_> = match cursor.kind() {
+        let mut args: Vec<_> = match kind {
             CXCursor_FunctionDecl |
             CXCursor_Constructor |
             CXCursor_CXXMethod |

tests/expectations/tests/issue-1464.rs

@@ -0,0 +1,8 @@
+/* automatically generated by rust-bindgen */
+
+#![allow(
+    dead_code,
+    non_snake_case,
+    non_camel_case_types,
+    non_upper_case_globals
+)]

tests/headers/issue-1464.hpp

@@ -0,0 +1,6 @@
+
+// Should not crash.
+template <int Foo> class Bar {
+public:
+  Bar();
+};

tests/tests.rs

@@ -207,7 +207,7 @@ fn compare_generated_header(
         expectation_file.write_all(actual.as_bytes())?;
     }
 
-    Err(Error::new(ErrorKind::Other, "Header and binding differ!"))
+    Err(Error::new(ErrorKind::Other, "Header and binding differ! Run with BINDGEN_OVERWRITE_EXPECTED=1 in the environment to automatically overwrite the expectation."))
 }
 
 fn create_bindgen_builder(header: &PathBuf) -> Result<Option<Builder>, Error> {