Auto merge of #168 - KiChjang:diagnostic-drop, r=emilio

bors-servo · web-flow · commit 146078744e48 · 2016-10-30T11:50:38.000-05:00
Implement Drop for Diagnostic I built it and ran the test, and they all pass. Not sure what else there is to test for. Fixes #145.
diff --git a/src/clang.rs b/src/clang.rs
@@ -1047,9 +1047,11 @@ impl Diagnostic {
             clang_getDiagnosticSeverity(self.x)
         }
     }
+}
 
+impl Drop for Diagnostic {
     /// Destroy this diagnostic message.
-    pub fn dispose(&self) {
+    fn drop(&mut self) {
         unsafe {
             clang_disposeDiagnostic(self.x);
         }

Original file line number	Diff line number	Diff line change
`@@ -1047,9 +1047,11 @@ impl Diagnostic {`
`1047`	`1047`	`clang_getDiagnosticSeverity(self.x)`
`1048`	`1048`	`}`
`1049`	`1049`	`}`
	`1050`	`+}`
`1050`	`1051`
	`1052`	`+impl Drop for Diagnostic {`
`1051`	`1053`	`/// Destroy this diagnostic message.`
`1052`		`- pub fn dispose(&self) {`
	`1054`	`+ fn drop(&mut self) {`
`1053`	`1055`	`unsafe {`
`1054`	`1056`	`clang_disposeDiagnostic(self.x);`
`1055`	`1057`	`}`