Render * repeats in forward direction

There are two ways to render a "zero or more" (i.e. `*`) repeat.  One
is to put nothing on the main forward line and to put the pattern on
the recurrent edge, and the other is to put the pattern on the main
forward line and to have an empty recurrent edge and an empty bypass
edge.

That is, for the latter, we can think of `thing*` as `(thing+)?`.

Doing it that latter way means an additional edge, but it buys us
something big in return, which is that it keeps all the patterns going
in the forward direction.  Doing it the other way means the patterns
have to be reversed so as to put them underneath on that recurrent
edge, and it means that readers then have to read them right to left.

Reversing the elements also causes a bug in some diagrams where the
lines end up running in opposing directions and so the trains crash
into each other.  See:

- #1787 (comment)

Keeping things in the forward direction avoids this problem.

In this commit, we'll leave in place all the infrastructure for
reversing the elements though it is no longer used.  We can of course
pull this out later.

Author: traviscross

Diff for: mdbook-spec/src/grammar/render_railroad.rs

@@ -163,15 +163,12 @@ impl Expression {
                 Box::new(Optional::new(n))
             }
             ExpressionKind::Repeat(e) => {
-                // Railroad renders everything in the opposite order. However,
-                // our grammar is not written that way, so we need to undo the
-                // reversal.
-                let n = e.render_railroad(stack, link_map, !reverse)?;
-                Box::new(Repeat::new(railroad::Empty, n))
+                let n = e.render_railroad(stack, link_map, reverse)?;
+                Box::new(Optional::new(Repeat::new(n, railroad::Empty)))
             }
             ExpressionKind::RepeatNonGreedy(e) => {
-                let n = e.render_railroad(stack, link_map, !reverse)?;
-                let r = Box::new(Repeat::new(railroad::Empty, n));
+                let n = e.render_railroad(stack, link_map, reverse)?;
+                let r = Box::new(Optional::new(Repeat::new(n, railroad::Empty)));
                 let lbox = LabeledBox::new(r, Comment::new("non-greedy".to_string()));
                 Box::new(lbox)
             }