Skip to content

Commit 0961cef

Browse files
authored
Rollup merge of #128150 - BoxyUwU:std_only_sized_const_params, r=workingjubilee
Stop using `unsized_const_parameters` in core/std `feature(unsized_const_parameters)` is an incomplete feature and should not be used by core/std as it makes it can make it significantly harder to evolve the feature. It also just generally opens the possibility of introducing bugs on stable through std's backdoor. The only usage of this feature in std is the `simd_shuffle_intrinsic` added in #119213. It doesn't seem to be used anywhere as far as I can tell so it is removed in this PR. All tests and codegen logic etc have been kept however. r? `@workingjubilee`
2 parents ea5a4cf + 700158c commit 0961cef

File tree

1 file changed

+14
-1
lines changed

1 file changed

+14
-1
lines changed

tests/pass/intrinsics/portable-simd.rs

+14-1
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,23 @@
11
//@compile-flags: -Zmiri-strict-provenance
2-
#![feature(portable_simd, adt_const_params, core_intrinsics, repr_simd)]
2+
#![feature(
3+
portable_simd,
4+
unsized_const_params,
5+
adt_const_params,
6+
rustc_attrs,
7+
intrinsics,
8+
core_intrinsics,
9+
repr_simd
10+
)]
311
#![allow(incomplete_features, internal_features)]
412
use std::intrinsics::simd as intrinsics;
513
use std::ptr;
614
use std::simd::{prelude::*, StdFloat};
715

16+
extern "rust-intrinsic" {
17+
#[rustc_nounwind]
18+
pub fn simd_shuffle_generic<T, U, const IDX: &'static [u32]>(x: T, y: T) -> U;
19+
}
20+
821
fn simd_ops_f32() {
922
let a = f32x4::splat(10.0);
1023
let b = f32x4::from_array([1.0, 2.0, 3.0, -4.0]);

0 commit comments

Comments
 (0)