Skip to content

Commit fb46377

Browse files
committed
[builtins] Fix undefined behavior in negdi2.c and negti2.c
When compiling the builtins with the undefined behavior sanitizer and running testcases you end up with the following warning: UBSan: negdi2.c:20:10: negation of -9223372036854775808 cannot be represented in type 'di_int' (aka 'long long'); cast to an unsigned type to negate this value to itself This can be avoided by doing negation in a matching unsigned variant of the type. The same kind of pattern is found in negti2.c This was found in an out of tree target. Reviewed By: MaskRay Differential Revision: https://reviews.llvm.org/D158818
1 parent 56255e0 commit fb46377

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

compiler-rt/lib/builtins/negdi2.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,5 +17,5 @@
1717
COMPILER_RT_ABI di_int __negdi2(di_int a) {
1818
// Note: this routine is here for API compatibility; any sane compiler
1919
// should expand it inline.
20-
return -a;
20+
return -(du_int)a;
2121
}

compiler-rt/lib/builtins/negti2.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
COMPILER_RT_ABI ti_int __negti2(ti_int a) {
2020
// Note: this routine is here for API compatibility; any sane compiler
2121
// should expand it inline.
22-
return -a;
22+
return -(tu_int)a;
2323
}
2424

2525
#endif // CRT_HAS_128BIT

0 commit comments

Comments
 (0)