Skip to content

Commit d7f9220

Browse files
committed
[MLIR] [AMDGPU] Use correct flags when building SerializeToHsaco
The SerializeToHsaco pass does not depend on ROCm being available on the build system - it only requires ROCm to be present at runtime. However, the CMake file that built it tested for MLIR_ENABLE_ROCM_RUNNER , which implies that ROCm is currently available and is used to control building ROCm integration tests. Referencing MLIR_ENABLE_ROCM_RUNNER instead of MLIR_ENABLE_ROCM_CONVERSIONS in the SerializeToHsaco build therefore causes problems for clients who wish to build projects that depend on this pass on a system without an AMD GPU present. Reviewed By: whchung Differential Revision: https://reviews.llvm.org/D120663
1 parent 7e57030 commit d7f9220

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

mlir/lib/Dialect/GPU/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ if(MLIR_ENABLE_CUDA_RUNNER)
119119

120120
endif()
121121

122-
if(MLIR_ENABLE_ROCM_RUNNER)
122+
if(MLIR_ENABLE_ROCM_CONVERSIONS)
123123
if (NOT ("AMDGPU" IN_LIST LLVM_TARGETS_TO_BUILD))
124124
message(SEND_ERROR
125125
"Building mlir with ROCm support requires the AMDGPU backend")

0 commit comments

Comments
 (0)