[lldb] Use assertIn/NotIn over assertTrue/False (NFC)

For improved failure messages, use `assertIn` over `assertTrue`.

Differential Revision: https://reviews.llvm.org/D96095

Author: kastiglione

lldb/test/API/commands/expression/dont_allow_jit/TestAllowJIT.py

@@ -69,7 +69,7 @@ def expr_options_test(self):
         # Again use it and ensure we fail:
         result = frame.EvaluateExpression("call_me(10)", options)
         self.assertTrue(result.GetError().Fail(), "expression failed with no JIT")
-        self.assertTrue("Can't evaluate the expression without a running target" in result.GetError().GetCString(), "Got right error")
+        self.assertIn("Can't evaluate the expression without a running target", result.GetError().GetCString(), "Got right error")
 
         # Finally set the allow JIT value back to true and make sure that works:
         options.SetAllowJIT(True)

lldb/test/API/commands/frame/var/TestFrameVar.py

@@ -64,28 +64,28 @@ def do_test(self):
         result = interp.HandleCommand("frame var -l", command_result)
         self.assertEqual(result, lldb.eReturnStatusSuccessFinishResult, "frame var -a didn't succeed")
         output = command_result.GetOutput()
-        self.assertTrue("argc" in output, "Args didn't find argc")
-        self.assertTrue("argv" in output, "Args didn't find argv")
-        self.assertTrue("test_var" not in output, "Args found a local")
-        self.assertTrue("g_var" not in output, "Args found a global")
+        self.assertIn("argc", output, "Args didn't find argc")
+        self.assertIn("argv", output, "Args didn't find argv")
+        self.assertNotIn("test_var", output, "Args found a local")
+        self.assertNotIn("g_var", output, "Args found a global")
 
         # Just get locals:
         result = interp.HandleCommand("frame var -a", command_result)
         self.assertEqual(result, lldb.eReturnStatusSuccessFinishResult, "frame var -a didn't succeed")
         output = command_result.GetOutput()
-        self.assertTrue("argc" not in output, "Locals found argc")
-        self.assertTrue("argv" not in output, "Locals found argv")
-        self.assertTrue("test_var" in output, "Locals didn't find test_var")
-        self.assertTrue("g_var" not in output, "Locals found a global")
+        self.assertNotIn("argc", output, "Locals found argc")
+        self.assertNotIn("argv", output, "Locals found argv")
+        self.assertIn("test_var", output, "Locals didn't find test_var")
+        self.assertNotIn("g_var", output, "Locals found a global")
 
         # Get the file statics:
         result = interp.HandleCommand("frame var -l -a -g", command_result)
         self.assertEqual(result, lldb.eReturnStatusSuccessFinishResult, "frame var -a didn't succeed")
         output = command_result.GetOutput()
-        self.assertTrue("argc" not in output, "Globals found argc")
-        self.assertTrue("argv" not in output, "Globals found argv")
-        self.assertTrue("test_var" not in output, "Globals found test_var")
-        self.assertTrue("g_var" in output, "Globals didn't find g_var")
+        self.assertNotIn("argc", output, "Globals found argc")
+        self.assertNotIn("argv", output, "Globals found argv")
+        self.assertNotIn("test_var", output, "Globals found test_var")
+        self.assertIn("g_var", output, "Globals didn't find g_var")
 
 
 

lldb/test/API/functionalities/breakpoint/breakpoint_names/TestBreakpointNames.py

@@ -288,14 +288,14 @@ def do_check_configuring_names(self):
         name_list = lldb.SBStringList()
         self.target.GetBreakpointNames(name_list)
         for name_string in [self.bp_name_string, other_bp_name_string, cl_bp_name_string]:
-            self.assertTrue(name_string in name_list, "Didn't find %s in names"%(name_string))
+            self.assertIn(name_string, name_list, "Didn't find %s in names"%(name_string))
 
         # Delete the name from the current target.  Make sure that works and deletes the
         # name from the breakpoint as well:
         self.target.DeleteBreakpointName(self.bp_name_string)
         name_list.Clear()
         self.target.GetBreakpointNames(name_list)
-        self.assertTrue(self.bp_name_string not in name_list, "Didn't delete %s from a real target"%(self.bp_name_string))
+        self.assertNotIn(self.bp_name_string, name_list, "Didn't delete %s from a real target"%(self.bp_name_string))
         # Also make sure the name got removed from breakpoints holding it:
         self.assertFalse(bkpt.MatchesName(self.bp_name_string), "Didn't remove the name from the breakpoint.")
 
@@ -305,7 +305,7 @@ def do_check_configuring_names(self):
         dummy_target.DeleteBreakpointName(self.bp_name_string)
         name_list.Clear()
         dummy_target.GetBreakpointNames(name_list)
-        self.assertTrue(self.bp_name_string not in name_list, "Didn't delete %s from the dummy target"%(self.bp_name_string))
+        self.assertNotIn(self.bp_name_string, name_list, "Didn't delete %s from the dummy target"%(self.bp_name_string))
         # Also make sure the name got removed from breakpoints holding it:
         self.assertFalse(bkpt.MatchesName(self.bp_name_string), "Didn't remove the name from the breakpoint.")
 

lldb/test/API/functionalities/breakpoint/debugbreak/TestDebugBreak.py

@@ -37,8 +37,8 @@ def test_asm_int_3(self):
         # We should be in funciton 'bar'.
         self.assertTrue(frame.IsValid())
         function_name = frame.GetFunctionName()
-        self.assertTrue('bar' in function_name,
-                        "Unexpected function name {}".format(function_name))
+        self.assertIn('bar', function_name,
+                      "Unexpected function name {}".format(function_name))
 
         # We should be able to evaluate the parameter foo.
         value = frame.EvaluateExpression('*foo')

lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/queue/TestDataFormatterLibcxxQueue.py

@@ -23,7 +23,7 @@ def check_variable(self, name):
         self.assertTrue(var.IsValid())
 
         queue = self.namespace + '::queue'
-        self.assertTrue(queue in var.GetDisplayTypeName())
+        self.assertIn(queue, var.GetDisplayTypeName())
         self.assertEqual(var.GetNumChildren(), 5)
         for i in range(5):
             ch = var.GetChildAtIndex(i)

lldb/test/API/functionalities/gdb_remote_client/TestGDBRemoteClient.py

@@ -96,7 +96,7 @@ def test_read_registers_using_p_packets(self):
         process = self.connect(target)
 
         self.read_registers(process)
-        self.assertFalse("g" in self.server.responder.packetLog)
+        self.assertNotIn("g", self.server.responder.packetLog)
         self.assertGreater(
                 len([p for p in self.server.responder.packetLog if p.startswith("p")]), 0)
 

lldb/test/API/functionalities/history/TestHistoryRecall.py

@@ -30,8 +30,8 @@ def sample_test(self):
 
         interp.HandleCommand("!0", result, False)
         self.assertTrue(result.Succeeded(), "!0 command did not work: %s"%(result.GetError()))
-        self.assertTrue("session history" in result.GetOutput(), "!0 didn't rerun session history")
+        self.assertIn("session history", result.GetOutput(), "!0 didn't rerun session history")
 
         interp.HandleCommand("!-1", result, False)
         self.assertTrue(result.Succeeded(), "!-1 command did not work: %s"%(result.GetError()))
-        self.assertTrue("host:" in result.GetOutput(), "!-1 didn't rerun platform list.")
+        self.assertIn("host:", result.GetOutput(), "!-1 didn't rerun platform list.")

lldb/test/API/functionalities/plugins/python_os_plugin/stepping_plugin_threads/TestOSPluginStepping.py

@@ -113,6 +113,6 @@ def run_python_os_step_missing_thread(self, do_prune):
             self.process.Continue()
             os_thread = self.get_os_thread()
             self.assertTrue(os_thread.IsValid(), "The OS thread is back after continue")
-            self.assertTrue("step out" in os_thread.GetStopDescription(100), "Completed step out plan")
+            self.assertIn("step out", os_thread.GetStopDescription(100), "Completed step out plan")
 
 

lldb/test/API/functionalities/postmortem/minidump-new/TestMiniDumpNew.py

@@ -110,7 +110,7 @@ def test_memory_region_name(self):
             ci.HandleCommand(command, result, False)
             message = 'Ensure memory "%s" shows up in output for "%s"' % (
                 region_name, command)
-            self.assertTrue(region_name in result.GetOutput(), message)
+            self.assertIn(region_name, result.GetOutput(), message)
 
     def test_thread_info_in_minidump(self):
         """Test that lldb can read the thread information from the Minidump."""
@@ -122,7 +122,7 @@ def test_thread_info_in_minidump(self):
         thread = self.process.GetThreadAtIndex(0)
         self.assertEqual(thread.GetStopReason(), lldb.eStopReasonSignal)
         stop_description = thread.GetStopDescription(256)
-        self.assertTrue("SIGSEGV" in stop_description)
+        self.assertIn("SIGSEGV", stop_description)
 
     def test_stack_info_in_minidump(self):
         """Test that we can see a trivial stack in a breakpad-generated Minidump."""
@@ -333,7 +333,7 @@ def do_test_deeper_stack(self, binary, core, pid):
             frame = thread.GetFrameAtIndex(index)
             self.assertTrue(frame.IsValid())
             function_name = frame.GetFunctionName()
-            self.assertTrue(name in function_name)
+            self.assertIn(name, function_name)
 
     @skipIfLLVMTargetMissing("X86")
     def test_deeper_stack_in_minidump(self):

lldb/test/API/functionalities/postmortem/minidump/TestMiniDump.py

@@ -38,7 +38,7 @@ def test_thread_info_in_mini_dump(self):
         thread = self.process.GetThreadAtIndex(0)
         self.assertEqual(thread.GetStopReason(), lldb.eStopReasonException)
         stop_description = thread.GetStopDescription(256)
-        self.assertTrue("0xc0000005" in stop_description)
+        self.assertIn("0xc0000005", stop_description)
 
     def test_modules_in_mini_dump(self):
         """Test that lldb can read the list of modules from the minidump."""
@@ -136,7 +136,7 @@ def test_deeper_stack_in_mini_dump(self):
                 frame = thread.GetFrameAtIndex(index)
                 self.assertTrue(frame.IsValid())
                 function_name = frame.GetFunctionName()
-                self.assertTrue(name in function_name)
+                self.assertIn(name, function_name)
 
         finally:
             # Clean up the mini dump file.

lldb/test/API/functionalities/process_save_core/TestProcessSaveCore.py

@@ -56,7 +56,7 @@ def test_save_windows_mini_dump(self):
                 os.path.join(
                     f.GetDirectory(),
                     f.GetFilename()) for f in files]
-            self.assertTrue(exe in paths)
+            self.assertIn(exe, paths)
 
         finally:
             # Clean up the mini dump file.

lldb/test/API/functionalities/source-map/TestTargetSourceMap.py

@@ -24,7 +24,7 @@ def assertBreakpointWithSourceMap(src_path):
             self.dbg.GetCommandInterpreter().HandleCommand("source list -f main.c -l 2", retval)
             self.assertTrue(retval.Succeeded(), "source list didn't succeed.")
             self.assertNotEqual(retval.GetOutput(), None, "We got no ouput from source list")
-            self.assertTrue("return" in retval.GetOutput(), "We didn't find the source file...")
+            self.assertIn("return", retval.GetOutput(), "We didn't find the source file...")
 
         # Set the target soure map to map "./" to the current test directory
         src_dir = self.getSourceDir()

lldb/test/API/functionalities/stats_api/TestStatisticsAPI.py

@@ -28,7 +28,7 @@ def test_stats_api(self):
         res = stats.GetAsJSON(stream)
         stats_json = sorted(json.loads(stream.GetData()))
         self.assertEqual(len(stats_json), 4)
-        self.assertTrue("Number of expr evaluation failures" in stats_json)
-        self.assertTrue("Number of expr evaluation successes" in stats_json)
-        self.assertTrue("Number of frame var failures" in stats_json)
-        self.assertTrue("Number of frame var successes" in stats_json)
+        self.assertIn("Number of expr evaluation failures", stats_json)
+        self.assertIn("Number of expr evaluation successes", stats_json)
+        self.assertIn("Number of frame var failures", stats_json)
+        self.assertIn("Number of frame var successes", stats_json)

lldb/test/API/functionalities/step_scripted/TestStepScripted.py

@@ -59,7 +59,7 @@ def test_misspelled_plan_name(self):
         # Make sure we got a good error:
         self.assertTrue(err.Fail(), "We got a failure state")
         msg = err.GetCString()
-        self.assertTrue("NoSuchModule.NoSuchPlan" in msg, "Mentioned missing class")
+        self.assertIn("NoSuchModule.NoSuchPlan", msg, "Mentioned missing class")
 
         # Make sure we didn't let the process run:
         self.assertEqual(stop_id, process.GetStopID(), "Process didn't run")

lldb/test/API/functionalities/tail_call_frames/cross_dso/TestCrossDSOTailCalls.py

@@ -61,5 +61,5 @@ def test_cross_dso_tail_calls(self):
         ]
         for idx, (name, is_artificial) in enumerate(expected_frames):
             frame = thread.GetFrameAtIndex(idx)
-            self.assertTrue(name in frame.GetDisplayFunctionName())
+            self.assertIn(name, frame.GetDisplayFunctionName())
             self.assertEqual(frame.IsArtificial(), is_artificial)

lldb/test/API/functionalities/tail_call_frames/cross_object/TestCrossObjectTailCalls.py

@@ -56,5 +56,5 @@ def test_cross_object_tail_calls(self):
         ]
         for idx, (name, is_artificial) in enumerate(expected_frames):
             frame = thread.GetFrameAtIndex(idx)
-            self.assertTrue(name in frame.GetDisplayFunctionName())
+            self.assertIn(name, frame.GetDisplayFunctionName())
             self.assertEqual(frame.IsArtificial(), is_artificial)

lldb/test/API/functionalities/tail_call_frames/sbapi_support/TestTailCallFrameSBAPI.py

@@ -61,5 +61,5 @@ def do_test(self):
             # platform-dependent. E.g we see "void sink(void)" on Windows, but
             # "sink()" on Darwin. This seems like a bug -- just work around it
             # for now.
-            self.assertTrue(name in frame.GetDisplayFunctionName())
+            self.assertIn(name, frame.GetDisplayFunctionName())
             self.assertEqual(frame.IsArtificial(), is_artificial)

lldb/test/API/functionalities/tsan/basic/TestTsanBasic.py

@@ -63,7 +63,7 @@ def tsan_tests(self):
         process = self.dbg.GetSelectedTarget().process
         thread = process.GetSelectedThread()
         frame = thread.GetSelectedFrame()
-        self.assertTrue("__tsan_on_report" in frame.GetFunctionName())
+        self.assertIn("__tsan_on_report", frame.GetFunctionName())
 
         # The stopped thread backtrace should contain either line1 or line2
         # from main.c.

lldb/test/API/functionalities/ubsan/basic/TestUbsanBasic.py

@@ -51,7 +51,7 @@ def ubsan_tests(self):
             substrs=['1 match found'])
 
         # We should be stopped in __ubsan_on_report
-        self.assertTrue("__ubsan_on_report" in frame.GetFunctionName())
+        self.assertIn("__ubsan_on_report", frame.GetFunctionName())
 
         # The stopped thread backtrace should contain either 'align line'
         found = False

lldb/test/API/lang/c/vla/TestVLA.py

@@ -24,7 +24,7 @@ def test_variable_list(self):
         var_opts.SetUseDynamic(lldb.eDynamicCanRunTarget)
         all_locals = self.frame().GetVariables(var_opts)
         for value in all_locals:
-            self.assertFalse("vla_expr" in value.name)
+            self.assertNotIn("vla_expr", value.name)
 
     @decorators.skipIf(compiler="clang", compiler_version=['<', '8.0'])
     def test_vla(self):

lldb/test/API/lang/cpp/accelerator-table/TestCPPAccelerator.py

@@ -29,7 +29,7 @@ def test(self):
         n = 0
         for line in log:
             if re.findall(r'[abcdefg]\.o: FindByNameAndTag\(\)', line):
-                self.assertTrue("d.o" in line)
+                self.assertIn("d.o", line)
                 n += 1
 
         self.assertEqual(n, 1, log)

lldb/test/API/lang/cpp/class_static/TestStaticVariables.py

@@ -138,7 +138,7 @@ def test_with_python_api(self):
         for val in valList:
             self.DebugSBValue(val)
             name = val.GetName()
-            self.assertTrue(name in ['g_points', 'A::g_points'])
+            self.assertIn(name, ['g_points', 'A::g_points'])
             if name == 'g_points':
                 self.assertEqual(
                     val.GetValueType(), lldb.eValueTypeVariableStatic)

lldb/test/API/lang/cpp/class_types/TestClassTypes.py

@@ -220,5 +220,5 @@ def test_with_constructor_name(self):
         frame = thread.frames[0]
         self.assertTrue(frame.IsValid(), "Got a valid frame.")
 
-        self.assertTrue("C::C" in frame.name,
-                        "Constructor name includes class name.")
+        self.assertIn("C::C", frame.name,
+                      "Constructor name includes class name.")

lldb/test/API/lang/objc/direct-dispatch-step/TestObjCDirectDispatchStepping.py

@@ -36,7 +36,7 @@ def test_with_python_api(self):
         for idx in range(2,16):
             thread.StepInto()
             func_name = thread.GetFrameAtIndex(0).GetFunctionName()
-            self.assertTrue("OverridesALot" in func_name, "%d'th step did not match name: %s"%(idx, func_name))
+            self.assertIn("OverridesALot", func_name, "%d'th step did not match name: %s"%(idx, func_name))
             stop_threads = lldbutil.continue_to_breakpoint(process, stop_bkpt)
             self.assertEqual(len(stop_threads), 1)
             self.assertEqual(stop_threads[0], thread)

lldb/test/API/lang/objc/exceptions/TestObjCExceptions.py

@@ -123,7 +123,7 @@ def test_objc_exceptions_at_throw(self):
         pcs = [i.unsigned for i in children]
         names = [target.ResolveSymbolContextForAddress(lldb.SBAddress(pc, target), lldb.eSymbolContextSymbol).GetSymbol().name for pc in pcs]
         for n in ["objc_exception_throw", "foo(int)", "main"]:
-            self.assertTrue(n in names, "%s is in the exception backtrace (%s)" % (n, names))
+            self.assertIn(n, names, "%s is in the exception backtrace (%s)" % (n, names))
 
     def test_objc_exceptions_at_abort(self):
         self.build()

lldb/test/API/lang/objc/objc-checker/TestObjCCheckers.py

@@ -73,7 +73,7 @@ def test_objc_checker(self):
 
         # Make sure the error is helpful:
         err_string = expr_error.GetCString()
-        self.assertTrue("selector" in err_string)
+        self.assertIn("selector", err_string)
 
         #
         # Check that we correctly insert the checker for an

lldb/test/API/macosx/macCatalyst/TestMacCatalyst.py

@@ -31,7 +31,7 @@ def test_macabi(self):
     def check_debugserver(self, log):
         """scan the debugserver packet log"""
         process_info = lldbutil.packetlog_get_process_info(log)
-        self.assertTrue('ostype' in process_info)
+        self.assertIn('ostype', process_info)
         self.assertEquals(process_info['ostype'], 'maccatalyst')
 
         aout_info = None

lldb/test/API/macosx/macCatalystAppMacOSFramework/TestMacCatalystAppWithMacOSFramework.py

@@ -34,7 +34,7 @@ def test(self):
     def check_debugserver(self, log):
         """scan the debugserver packet log"""
         process_info = lldbutil.packetlog_get_process_info(log)
-        self.assertTrue('ostype' in process_info)
+        self.assertIn('ostype', process_info)
         self.assertEquals(process_info['ostype'], 'maccatalyst')
 
         aout_info = None

lldb/test/API/macosx/simulator/TestSimulatorPlatform.py

@@ -29,7 +29,7 @@ def check_load_commands(self, expected_load_command):
     def check_debugserver(self, log, expected_platform, expected_version):
         """scan the debugserver packet log"""
         process_info = lldbutil.packetlog_get_process_info(log)
-        self.assertTrue('ostype' in process_info)
+        self.assertIn('ostype', process_info)
         self.assertEquals(process_info['ostype'], expected_platform)
         dylib_info = lldbutil.packetlog_get_dylib_info(log)
         self.assertTrue(dylib_info)

lldb/test/API/tools/lldb-server/TestGdbRemoteAuxvSupport.py

@@ -35,7 +35,7 @@ def get_raw_auxv_data(self):
 
         proc_info = self.parse_process_info_response(context)
         self.assertIsNotNone(proc_info)
-        self.assertTrue("ptrsize" in proc_info)
+        self.assertIn("ptrsize", proc_info)
         word_size = int(proc_info["ptrsize"])
 
         OFFSET = 0

lldb/test/API/tools/lldb-server/TestGdbRemoteExpeditedRegisters.py

@@ -54,7 +54,7 @@ def stop_notification_contains_generic_register(
         self.assertIsNotNone(reg_info)
 
         # Ensure the expedited registers contained it.
-        self.assertTrue(reg_info["lldb_register_index"] in expedited_registers)
+        self.assertIn(reg_info["lldb_register_index"], expedited_registers)
         self.trace("{} reg_info:{}".format(generic_register_name, reg_info))
 
     def test_stop_notification_contains_any_registers(self):
@@ -121,5 +121,5 @@ def test_stop_notification_contains_vg_register(self):
         self.assertIsNotNone(reg_info)
 
         # Ensure the expedited registers contained it.
-        self.assertTrue(reg_info["lldb_register_index"] in expedited_registers)
+        self.assertIn(reg_info["lldb_register_index"], expedited_registers)
         self.trace("{} reg_info:{}".format('vg', reg_info))

lldb/test/API/tools/lldb-server/TestGdbRemoteHostInfo.py

@@ -66,8 +66,8 @@ def parse_host_info_response(self, context):
 
         # Validate keys are known.
         for (key, val) in list(host_info_dict.items()):
-            self.assertTrue(key in self.KNOWN_HOST_INFO_KEYS,
-                            "unknown qHostInfo key: " + key)
+            self.assertIn(key, self.KNOWN_HOST_INFO_KEYS,
+                          "unknown qHostInfo key: " + key)
             self.assertIsNotNone(val)
 
         # Return the key:val pairs.

lldb/test/API/tools/lldb-server/TestGdbRemote_vCont.py

@@ -22,7 +22,7 @@ def vCont_supports_mode(self, mode, inferior_args=None):
         self.assertIsNotNone(supported_vCont_modes)
 
         # Verify we support the given mode.
-        self.assertTrue(mode in supported_vCont_modes)
+        self.assertIn(mode, supported_vCont_modes)
 
 
     def test_vCont_supports_c(self):