Skip to content

Bump libgit2 to 1.4.0 #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dtolnay opened this issue Feb 14, 2022 · 1 comment · Fixed by #806
Closed

Bump libgit2 to 1.4.0 #804

dtolnay opened this issue Feb 14, 2022 · 1 comment · Fixed by #806

Comments

@dtolnay
Copy link
Member

dtolnay commented Feb 14, 2022

https://github.com/libgit2/libgit2/releases/tag/v1.4.0 was just released and contains libgit2/libgit2#6203, which we need for unblocking fast fetches in Cargo: rust-lang/cargo#10078.

I tried naïvely bumping the libgit2 submodule like in #751 but cargo test has some test failures and several segfaults, so this may be a high-effort upgrade.

@alexcrichton
Copy link
Member

Typically this comes about because structures in C changed, but this can be tested with cargo run in the systest directory which should print out which structs in Rust are different than those in C. Once the libgit2-sys crate is adjusted that should probably weed out the segfaults.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants