Skip to content

Commit f36cf67

Browse files
committed
Avoid MaybeUninit in OdbPackwriter, too
1 parent a3067e7 commit f36cf67

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

src/odb.rs

+4-6
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
use std::io;
22
use std::marker;
3-
use std::mem::MaybeUninit;
43
use std::ptr;
54
use std::slice;
65

@@ -162,7 +161,6 @@ impl<'repo> Odb<'repo> {
162161
/// Create stream for writing a pack file to the ODB
163162
pub fn packwriter(&self) -> Result<OdbPackwriter<'_>, Error> {
164163
let mut out = ptr::null_mut();
165-
let progress = MaybeUninit::uninit();
166164
let progress_cb: raw::git_indexer_progress_cb = Some(write_pack_progress_cb);
167165
let progress_payload = Box::new(OdbPackwriterCb { cb: None });
168166
let progress_payload_ptr = Box::into_raw(progress_payload);
@@ -178,7 +176,7 @@ impl<'repo> Odb<'repo> {
178176

179177
Ok(OdbPackwriter {
180178
raw: out,
181-
progress,
179+
progress: Default::default(),
182180
progress_payload_ptr,
183181
})
184182
}
@@ -445,7 +443,7 @@ pub(crate) struct OdbPackwriterCb<'repo> {
445443
/// A stream to write a packfile to the ODB
446444
pub struct OdbPackwriter<'repo> {
447445
raw: *mut raw::git_odb_writepack,
448-
progress: MaybeUninit<raw::git_indexer_progress>,
446+
progress: raw::git_indexer_progress,
449447
progress_payload_ptr: *mut OdbPackwriterCb<'repo>,
450448
}
451449

@@ -455,7 +453,7 @@ impl<'repo> OdbPackwriter<'repo> {
455453
unsafe {
456454
let writepack = &*self.raw;
457455
let res = match writepack.commit {
458-
Some(commit) => commit(self.raw, self.progress.as_mut_ptr()),
456+
Some(commit) => commit(self.raw, &mut self.progress),
459457
None => -1,
460458
};
461459

@@ -489,7 +487,7 @@ impl<'repo> io::Write for OdbPackwriter<'repo> {
489487

490488
let writepack = &*self.raw;
491489
let res = match writepack.append {
492-
Some(append) => append(self.raw, ptr, len, self.progress.as_mut_ptr()),
490+
Some(append) => append(self.raw, ptr, len, &mut self.progress),
493491
None => -1,
494492
};
495493

0 commit comments

Comments
 (0)