Remove convenience functions + first try at a test

Author: blyxyas

src/build.rs

@@ -171,28 +171,6 @@ impl<'cb> RepoBuilder<'cb> {
         self
     }
 
-    /// Specify fetch depth, a value less than zero is interpreted as pull everything (effectively the same as no declaring a limit depth)
-    pub fn depth(&mut self, depth: i32) -> &mut RepoBuilder<'cb> {
-        if !self.fetch_opts.as_mut().is_some_and(|fetch_opts| {
-            fetch_opts.depth(depth);
-            true
-        }) {
-            let mut fo = FetchOptions::new();
-            fo.depth(depth);
-            self.fetch_options(fo);
-        }
-
-        self
-        // if let Some(ref fetch_opts) = &self.fetch_opts {
-        //     fetch_opts.depth(depth);
-        // } else {
-        //     let mut fo = FetchOptions::new();
-        //     fo.depth(depth);
-        //     self.fetch_options(fo);
-        // }
-        // self
-    }
-
     /// Specify the name of the branch to check out after the clone.
     ///
     /// If not specified, the remote's default branch will be used.

src/remote.rs

@@ -540,8 +540,12 @@ impl<'cb> FetchOptions<'cb> {
         self
     }
 
-    /// Set fetch depth, a value less than zero is interpreted as pull everything (effectively the same as no declaring a limit depth)
+    /// Set fetch depth, a value less or equal to 0 is interpreted as pull everything (effectively the same as not declaring a limit depth)
     pub fn depth(&mut self, depth: i32) -> &mut Self {
+        if depth.is_negative() {
+            self.depth = 0;
+            return self;
+        }
         self.depth = depth;
         self
     }
@@ -752,6 +756,7 @@ impl RemoteRedirect {
 
 #[cfg(test)]
 mod tests {
+    use crate::build::RepoBuilder;
     use crate::{AutotagOption, PushOptions};
     use crate::{Direction, FetchOptions, Remote, RemoteCallbacks, Repository};
     use std::cell::Cell;
@@ -1115,4 +1120,43 @@ mod tests {
         assert_eq!(flag, 7);
         assert_eq!(remote_repo.branches(None).unwrap().count(), 3);
     }
+
+    #[test]
+    fn shallow_clone() {
+        let (td, repo) = crate::test::repo_init();
+
+        let commit = repo.head().unwrap().target().unwrap();
+        let first_commit = repo.find_commit(commit).unwrap();
+
+        let sig = repo.signature().unwrap();
+        let mut index = repo.index().unwrap();
+        let tree = index.write_tree().unwrap();
+        let tree = repo.find_tree(tree).unwrap();
+
+        let second_commit = repo.commit(
+            Some("HEAD"),
+            &sig,
+            &sig,
+            "second commit",
+            &tree,
+            &[&first_commit]
+        ).unwrap();
+
+        let td2 = TempDir::new().unwrap();
+        let mut fo = FetchOptions::new();
+        fo.depth(1);
+
+        let new_repo = RepoBuilder::new()
+        .fetch_options(fo)
+        .clone(&td.into_path().as_os_str().to_str().unwrap(), td2.path())
+        .unwrap();
+
+        dbg!(new_repo.is_shallow());
+
+        let _ = dbg!(new_repo.find_commit(first_commit.id())); // ????
+        let _ = dbg!(new_repo.find_commit(second_commit));
+
+        // Check that there's only one commit
+        panic!();
+    }
 }

src/repo.rs

@@ -341,13 +341,6 @@ impl Repository {
         Ok(repo)
     }
 
-    /// Clone a remote repository with a depth of one (shallow cloning)
-    ///
-    /// Similar to `git clone --depth 1`
-    pub fn shallow_clone<P: AsRef<Path>>(url: &str, into: P) -> Result<Repository, Error> {
-        RepoBuilder::new().depth(1).clone(url, into.as_ref())
-    }
-
     /// Attempt to wrap an object database as a repository.
     pub fn from_odb(odb: Odb<'_>) -> Result<Repository, Error> {
         crate::init();