Skip to content

Commit 8b19841

Browse files
committed
add missing span.entered(), use span.in_scope
1 parent abc6683 commit 8b19841

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

src/docbuilder/rustwide_builder.rs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -407,12 +407,11 @@ impl RustwideBuilder {
407407
// fill up disk space.
408408
// This also prevents having multiple builders using the same rustwide workspace,
409409
// which we don't do. Currently our separate builders use a separate rustwide workspace.
410-
{
411-
let _span = info_span!("purge_all_build_dirs").entered();
410+
info_span!("purge_all_build_dirs").in_scope(|| {
412411
self.workspace
413412
.purge_all_build_dirs()
414-
.map_err(FailureError::compat)?;
415-
}
413+
.map_err(FailureError::compat)
414+
})?;
416415

417416
let mut build_dir = self.workspace.build_dir(&format!("{name}-{version}"));
418417

src/storage/mod.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -405,7 +405,7 @@ impl AsyncStorage {
405405

406406
let mut zip_content = {
407407
let _span =
408-
info_span!("create_zip_archive", %archive_path, root_dir=%root_dir.display());
408+
info_span!("create_zip_archive", %archive_path, root_dir=%root_dir.display()).entered();
409409

410410
let options = zip::write::FileOptions::default()
411411
.compression_method(zip::CompressionMethod::Bzip2);
@@ -427,7 +427,7 @@ impl AsyncStorage {
427427
let remote_index_path = format!("{}.index", &archive_path);
428428
let alg = CompressionAlgorithm::default();
429429
let compressed_index_content = {
430-
let _span = info_span!("create_archive_index", %remote_index_path);
430+
let _span = info_span!("create_archive_index", %remote_index_path).entered();
431431

432432
fs::create_dir_all(&temp_dir)?;
433433
let local_index_path =

0 commit comments

Comments
 (0)