Skip to content

Commit 67f5c17

Browse files
jyn514Joshua Nelson
authored and
Joshua Nelson
committed
Use &str instead of String
1 parent 0395368 commit 67f5c17

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

src/docbuilder/rustwide_builder.rs

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -457,25 +457,28 @@ impl RustwideBuilder {
457457
if let Some(package_rustdoc_args) = &metadata.rustdoc_args {
458458
rustdoc_flags.append(&mut package_rustdoc_args.iter().map(|s| s.to_owned()).collect());
459459
}
460-
let mut cargo_args = vec!["doc".to_owned(), "--lib".to_owned(), "--no-deps".to_owned()];
460+
let mut cargo_args = vec!["doc", "--lib", "--no-deps"];
461461
if target != HOST_TARGET {
462462
// If the explicit target is not a tier one target, we need to install it.
463463
if !TARGETS.contains(&target) {
464464
// This is a no-op if the target is already installed.
465465
self.toolchain.add_target(&self.workspace, target)?;
466466
}
467-
cargo_args.push("--target".to_owned());
468-
cargo_args.push(target.to_owned());
467+
cargo_args.push("--target");
468+
cargo_args.push(target);
469469
};
470+
471+
let tmp;
470472
if let Some(features) = &metadata.features {
471-
cargo_args.push("--features".to_owned());
472-
cargo_args.push(features.join(" "));
473+
cargo_args.push("--features");
474+
tmp = features.join(" ");
475+
cargo_args.push(&tmp);
473476
}
474477
if metadata.all_features {
475-
cargo_args.push("--all-features".to_owned());
478+
cargo_args.push("--all-features");
476479
}
477480
if metadata.no_default_features {
478-
cargo_args.push("--no-default-features".to_owned());
481+
cargo_args.push("--no-default-features");
479482
}
480483

481484
let mut storage = LogStorage::new(LevelFilter::Info);

0 commit comments

Comments
 (0)