show in-progress build on build page and crate details page

Author: syphar

.sqlx/query-3cb4dcb5778c77148aeb8dfc7f942ad45269ad7aab9e9c08fdaa9cb218dbc752.json

@@ -90,21 +90,24 @@ pub(crate) async fn build_list_json_handler(
             get_builds(&mut conn, &name, &version)
                 .await?
                 .iter()
-                .map(|build| {
+                .filter_map(|build| {
+                    if build.build_status == BuildStatus::InProgress {
+                        return None;
+                    }
                     // for backwards compatibility in this API, we
                     // * convert the build status to a boolean
                     // * already filter out in-progress builds
                     //
                     // even when we start showing in-progress builds in the UI,
                     // we might still not show them here for backwards
                     // compatibility.
-                    serde_json::json!({
+                    Some(serde_json::json!({
                         "id": build.id,
                         "rustc_version": build.rustc_version,
                         "docsrs_version": build.docsrs_version,
                         "build_status": build.build_status.is_success(),
                         "build_time": build.build_time,
-                    })
+                    }))
                 })
                 .collect::<Vec<_>>(),
         ),

.sqlx/query-e579486925d3d1927232675b2a03d5f8dd826d7136cdbba1331faf6e64c1f5eb.json renamed to .sqlx/query-771731efe02694173d758c04a4ec616e0171b05f09b71795af14270961fa8bd0.json

@@ -385,8 +385,7 @@ pub(crate) async fn releases_for_crate(
          FROM releases
          INNER JOIN release_build_status ON releases.id = release_build_status.rid
          WHERE
-             releases.crate_id = $1 AND
-             release_build_status.build_status != 'in_progress'"#,
+             releases.crate_id = $1"#,
         crate_id,
     )
     .fetch(&mut *conn)

src/web/builds.rs

@@ -306,7 +306,7 @@ async fn match_version(
     };
 
     // when matching semver requirements, we only want to look at non-yanked releases.
-    let flt = |r: &&Release| r.yanked == Some(false);
+    let flt = |r: &&Release| r.yanked.is_none() || r.yanked == Some(false);
 
     if let Some(release) = releases
         .iter()

src/web/crate_details.rs

@@ -42,7 +42,9 @@
                 <ul>
                     {%- for build in builds -%}
                         <li>
+                            {%- if build.build_status != "in_progress" %}
                             <a href="/crate/{{ metadata.name }}/{{ metadata.version }}/builds/{{ build.id }}" class="release">
+                            {%- endif %}
                                 <div class="pure-g">
                                     <div class="pure-u-1 pure-u-sm-1-24 build">
                                         {%- if build.build_status == "success" -%}
@@ -77,19 +79,12 @@
                                         {%- endif -%}
                                     </div>
                                 </div>
+                            {%- if build.build_status != "in_progress" %}
                             </a>
+                            {%- endif %}
                         </li>
                     {%- endfor -%}
                 </ul>
-            {%- else -%}
-                {# FIXME: temporarily this will never be shown since we hide in-progress releases for now #}
-                <div class="warning">
-                    docs.rs has not built {{ metadata.name }}-{{ metadata.version }}
-                    <br>
-                    It may still be <a href="/releases/queue">queued</a> or in-progress.
-                    <br>
-                    If you believe this is docs.rs' fault, <a href="https://github.com/rust-lang/docs.rs/issues/new/choose">open an issue</a>.
-                </div>
             {%- endif -%}
 
             <div class="about">