Skip to content

Commit 2897b8d

Browse files
Nemo157syphar
authored andcommitted
Add warning on build page if there are no builds
1 parent aac28ee commit 2897b8d

File tree

2 files changed

+41
-22
lines changed

2 files changed

+41
-22
lines changed

src/web/builds.rs

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -268,6 +268,15 @@ mod tests {
268268

269269
assert!(rows.is_empty());
270270

271+
let warning = page
272+
.select_first(".warning")
273+
.expect("missing warning element")
274+
.text_contents();
275+
276+
assert!(warning.contains("has not built"));
277+
assert!(warning.contains("queued"));
278+
assert!(warning.contains("open an issue"));
279+
271280
Ok(())
272281
});
273282
}

templates/crate/builds.html

Lines changed: 32 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -30,30 +30,40 @@
3030
{%- block body -%}
3131
<div class="container">
3232
<div class="recent-releases-container">
33-
<div class="release">
34-
<strong>Builds</strong>
35-
</div>
33+
{%- if builds -%}
34+
<div class="release">
35+
<strong>Builds</strong>
36+
</div>
3637

37-
<ul>
38-
{%- for build in builds -%}
39-
<li>
40-
<a href="/crate/{{ metadata.name }}/{{ metadata.version }}/builds/{{ build.id }}" class="release">
41-
<div class="pure-g">
42-
<div class="pure-u-1 pure-u-sm-1-24 build">
43-
{%- if build.build_status -%}
44-
{{ "check" | fas }}
45-
{%- else -%}
46-
{{ "x" | fas }}
47-
{%- endif -%}
38+
<ul>
39+
{%- for build in builds -%}
40+
<li>
41+
<a href="/crate/{{ metadata.name }}/{{ metadata.version }}/builds/{{ build.id }}" class="release">
42+
<div class="pure-g">
43+
<div class="pure-u-1 pure-u-sm-1-24 build">
44+
{%- if build.build_status -%}
45+
{{ "check" | fas }}
46+
{%- else -%}
47+
{{ "x" | fas }}
48+
{%- endif -%}
49+
</div>
50+
<div class="pure-u-1 pure-u-sm-10-24">{{ build.rustc_version }}</div>
51+
<div class="pure-u-1 pure-u-sm-10-24">{{ build.docsrs_version }}</div>
52+
<div class="pure-u-1 pure-u-sm-3-24 date">{{ build.build_time | timeformat(relative=true) }}</div>
4853
</div>
49-
<div class="pure-u-1 pure-u-sm-10-24">{{ build.rustc_version }}</div>
50-
<div class="pure-u-1 pure-u-sm-10-24">{{ build.docsrs_version }}</div>
51-
<div class="pure-u-1 pure-u-sm-3-24 date">{{ build.build_time | timeformat(relative=true) }}</div>
52-
</div>
53-
</a>
54-
</li>
55-
{%- endfor -%}
56-
</ul>
54+
</a>
55+
</li>
56+
{%- endfor -%}
57+
</ul>
58+
{%- else -%}
59+
<div class="warning">
60+
docs.rs has not built {{ metadata.name }}-{{ metadata.version }}
61+
<br>
62+
It may still be <a href="/releases/queue">queued</a> or in-progress.
63+
<br>
64+
If you believe this is docs.rs' fault, <a href="https://github.com/rust-lang/docs.rs/issues/new/choose">open an issue</a>.
65+
</div>
66+
{%- endif -%}
5767

5868
<div class="about">
5969
{# BuildsPage.metadata is an `Option<MetaData>`, so accessing it can fail #}

0 commit comments

Comments
 (0)