From a0ba31d87ddc98440bb47798c97bcb5024abbf21 Mon Sep 17 00:00:00 2001 From: pimterry Date: Wed, 3 Dec 2014 23:10:33 +0000 Subject: [PATCH 1/2] Add titles to crate pages --- app/initializers/document-title-config.js | 13 +++++++++++++ app/routes/application.js | 2 ++ app/routes/crate/index.js | 2 ++ package.json | 3 ++- 4 files changed, 19 insertions(+), 1 deletion(-) create mode 100644 app/initializers/document-title-config.js diff --git a/app/initializers/document-title-config.js b/app/initializers/document-title-config.js new file mode 100644 index 00000000000..a87e623955d --- /dev/null +++ b/app/initializers/document-title-config.js @@ -0,0 +1,13 @@ +import Ember from 'ember'; + +import DocumentTitle from "ember-document-title/mixins/document-title"; + +DocumentTitle.reopen({ + "titleSpecificityIncreases": false, + "titleDivider": "-" +}); + +export default { + name: "document-title-config", + initialize: function () {} +}; \ No newline at end of file diff --git a/app/routes/application.js b/app/routes/application.js index 0ca3a9fa709..c975c187540 100644 --- a/app/routes/application.js +++ b/app/routes/application.js @@ -2,6 +2,8 @@ import Ember from 'ember'; import ajax from 'ic-ajax'; export default Ember.Route.extend({ + title: "Cargo", + beforeModel: function() { var self = this; if (this.session.get('isLoggedIn') && diff --git a/app/routes/crate/index.js b/app/routes/crate/index.js index 97f7c449906..c8f2a10a7e2 100644 --- a/app/routes/crate/index.js +++ b/app/routes/crate/index.js @@ -4,6 +4,8 @@ import Version from 'cargo/models/version'; import Crate from 'cargo/models/crate'; export default Ember.Route.extend({ + title: Ember.computed.reads("controller.name"), + setupController: function(controller, data) { if (data instanceof Crate) { data = {crate: data, version: null}; diff --git a/package.json b/package.json index aa6dfc49ded..6a928176b25 100644 --- a/package.json +++ b/package.json @@ -29,6 +29,7 @@ "ember-cli-qunit": "0.1.0", "ember-data": "1.0.0-beta.10", "express": "^4.8.5", - "glob": "^4.0.5" + "glob": "^4.0.5", + "ember-document-title": "~0.1.2" } } From 4b6138684c1fea2874fbba72dc6ea944a1ed9e84 Mon Sep 17 00:00:00 2001 From: pimterry Date: Wed, 3 Dec 2014 23:29:45 +0000 Subject: [PATCH 2/2] Remove unused 'Ember' import in title config --- app/initializers/document-title-config.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/app/initializers/document-title-config.js b/app/initializers/document-title-config.js index a87e623955d..8ed43b32f44 100644 --- a/app/initializers/document-title-config.js +++ b/app/initializers/document-title-config.js @@ -1,5 +1,3 @@ -import Ember from 'ember'; - import DocumentTitle from "ember-document-title/mixins/document-title"; DocumentTitle.reopen({