Skip to content

Still duplicated items in search result. #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kennytm opened this issue Apr 23, 2017 · 4 comments
Closed

Still duplicated items in search result. #685

kennytm opened this issue Apr 23, 2017 · 4 comments
Labels
A-search C-bug 🐞 Category: unintended, undesired behavior

Comments

@kennytm
Copy link
Member

kennytm commented Apr 23, 2017

Test case (2017-04-23):

  1. Go to https://crates.io/search?q=address (Search for "address", sort by "relevance")
  2. There should be 126 results reported, split into 13 pages.
  3. Check the result of each page (run $('.desc > .info > a').map((t, v) => v.innerText).toArray() in console):
    1. ipaddress, addressable-pairing-heap, generic-dns-update, ipgen-cli, delix, tokio-http2, addr2line, bind_before_connect, maidsafe_vault, gip
    2. gip, bind_before_connect, publicsuffix, memrange, coinaddress, serde_json, smoltcp, iban_validate, rbpf, timi
    3. fel-cli, eui48, sbrain, fake, ipnetwork, wping, fastchemail, base58, stable_deref_trait, safe-builder-derive
    4. safe-builder-derive, ipecho, fast_chemail, sendmail, maidsafe_types, acto-rs, rzbackup, ip, partners, ip6gen
    5. acto-rs, toa-ping, gl, tfs, ipify, asm6502, faker, sozu-command-lib, cidrr, throw
    6. cafs, ipify, sozu-command-lib, throw, asm6502, netaddr, letsencrypt-rs, mates, ralloc, cidrr
    7. scanner, backtrace, msgpacknet, cafs, fibers, conshash, emailaddress, get_if_addrs, tagua-parser, signifix
    8. vectorclock-rs, path, libproc, psl, tagua-llvm, lia, multiboot, dotenv_codegen, fsuipc, clap
    9. subotai, rsure, domain, nom, stellaris-launchpad, rustful, fractal-utils, rubbish, treebitmap, rusty-blockparser
    10. oscpad, dht, lettre, tftp_server, aerospike, igd, fs_eventbridge, koukku, hexplay, pistoncore-glfw_window
    11. dotenv, uuid, multiaddr, wesers, lovesense, resolve, austenite, finch, dotenv_macros, dcpu16-gui
    12. routing, zlib, gl_generator, blorb, glutin, spread, cuticula, cmail, encoding_rs, parking_lot
    13. bitcoin, twists, kvm, iron, cpuio, vat
  4. Note how 10 results are randomly duplicated in the first few pages.

Another search page may has similar results:

  • https://crates.io/search?q=macos (53 results, 5 duplicates):
    1. ssh_bookmarker, enigo, cage, qcow2-fuse, rat, mac-notification-sys, gmp-mpfr-sys, notify-rust, osascript, emoji-commit
    2. context_bind, ring, adi, emoji-commit, freefare, vgrs, tantivy, rugrat, tutil, opencv
    3. rusty-tags, subprocess, auxv, coarsetime, rucaja, amqp, tokei, git-brws, substudy, dcpu16-gui
    4. rugcom, free-space-wipe, process_path, lua, keystroke, fs_eventbridge, shoop, region, djangohashers, javascriptcore-sys
    5. rugrat, opencv, tantivy, gog-sync, tutil, vgrs, an-rope, rugflo, kic, flatbuffers
    6. openssl, pcsc, perfcnt
  • There is no problem when sorted by downloads:
    1. openssl, ring, context, tokei, rusty-tags, notify-rust, amqp, lua, webbrowser, substudy
    2. djangohashers, opencv, cage, perfcnt, dcpu16-gui, vgrs, gmp-mpfr-sys, keystroke, subprocess, shoop
    3. tantivy, rucaja, flatbuffers, tutil, coarsetime, rugint, freefare, rugrat, kic, kaws
    4. git-brws, rugflo, region, enigo, pcsc, auxv, an-rope, qcow2-fuse, emoji-commit, philips_hue_client
    5. rugcom, fs_eventbridge, context_bind, process_path, free-space-wipe, ssh_bookmarker, mac-notification-sys, git-interactive-rebase-tool, javascriptcore-sys, gog-sync
    6. osascript, rat, adi
  • From this we can see the crates context, webbrowser, rugint, philips_hue_client and git-interactive-rebase-tool are hidden from the relevant view.

cc #162, #199 (@gkoz), not sure if the fix is really deployed.

@carols10cents
Copy link
Member

0e491f4 is certainly in the master branch, we probably re-broke it in the switch to diesel.

@killercup
Copy link
Member

I think I'm seeing this as well with https://crates.io/search?page=6&q=derive

@carols10cents carols10cents added the C-bug 🐞 Category: unintended, undesired behavior label Aug 2, 2017
@Deedasmi
Copy link
Contributor

Deedasmi commented Sep 28, 2017

Appears to be resolved.

richardp@localhost:~/crates_scrape|
⇒  cargo search --limit 100 derive | cut -d " " -f 1 | uniq -cd
    Updating registry `https://github.com/rust-lang/crates.io-index`
richardp@localhost:~/crates_scrape|
⇒  cargo search --limit 100 address | cut -d " " -f 1 | uniq -cd
    Updating registry `https://github.com/rust-lang/crates.io-index`
richardp@localhost~/crates_scrape|
⇒  cargo search --limit 100 macos | cut -d " " -f 1 | uniq -cd
    Updating registry `https://github.com/rust-lang/crates.io-index`

EDIT: Also checked the first 10 pages of the address search on crates.io with no duplicates.

@sgrif
Copy link
Contributor

sgrif commented Sep 28, 2017

Looks resolved to me as well.

@sgrif sgrif closed this as completed Sep 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-search C-bug 🐞 Category: unintended, undesired behavior
Projects
None yet
Development

No branches or pull requests

5 participants