Skip to content

Stats: Ignore downloads made by bots #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pczarn opened this issue Jul 16, 2016 · 7 comments
Closed

Stats: Ignore downloads made by bots #386

pczarn opened this issue Jul 16, 2016 · 7 comments
Labels
C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works

Comments

@pczarn
Copy link

pczarn commented Jul 16, 2016

Crates are often downloaded by crater, travis and other automatic tools. This doesn't reflect real use. Beginners might be confused by rising download counts on their newly uploaded crates.

It's better to ignore these downloads. Alternatively, display separate stats categories for both kinds of downloads.

@tshepang
Copy link
Member

What about automatic dependencies (i.e. those not listed in Cargo.toml)?

@carols10cents carols10cents added the C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works label Dec 15, 2016
@Eh2406
Copy link
Contributor

Eh2406 commented Mar 15, 2017

cc# #110 (comment)

@carols10cents
Copy link
Member

I don't know of a way we can reliably detect the difference between a legitimate download and bot downloads. In addition to download numbers inflated by bots, download numbers are likely also deflated by caches. The download number is always going to be inherently fuzzy, so I'm giving this a close.

@pczarn
Copy link
Author

pczarn commented Sep 14, 2017

To detect the difference, bots could be modified to say they're bots while communicating with crates.io. However, you may be right about caches.

@tshepang
Copy link
Member

It is better to have a lower number (caches) than an inflated number (bots), so having bots say they are bots is one thing, but even better would be if cargo can detect if it's being run manually.

@Mubelotix
Copy link

It's necessary

@jhg
Copy link

jhg commented Dec 24, 2020

Maybe downloads done by bots are legitimate in some cases and "manual" not.

One can automate downloads to inflate #. Also an CD (with cache) can download it and maybe I don't download it manually. I'm not sure if that example is less real than if I do manually. Also other devs download it, or same dev in different machines. It's not 1:1 "crate x.y.z download":"crate using it".

If requests identify itself for not count twice, or more, maybe. Or show it separately. It's only IMHO.

EDIT: Dependent crates # could help to know usage, but only by published crates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works
Projects
None yet
Development

No branches or pull requests

6 participants