Skip to content

Using 'Showing stats for' dropdown reset scrollbar #1275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Aaron1011 opened this issue Mar 16, 2018 · 3 comments · Fixed by #1854
Closed

Using 'Showing stats for' dropdown reset scrollbar #1275

Aaron1011 opened this issue Mar 16, 2018 · 3 comments · Fixed by #1854
Assignees
Labels
A-frontend 🐹 C-bug 🐞 Category: unintended, undesired behavior

Comments

@Aaron1011
Copy link
Member

Aaron1011 commented Mar 16, 2018

Selecting a version from the 'Showing stats for' dropdown causes the scrollbar to be reset to the top of the page. It would be nice if the page remained scrolled to the 'Stats' section after using the dropdown.

While this is a fairly minor issue, it can be somewhat annoying on pages with large READMEs, where where 'Stats' section is below the fold.

@sgrif
Copy link
Contributor

sgrif commented May 3, 2018

I don't think there's any way we can actually "fix" this issue. Ultimately this boils down to some UI confusion. "Showing stats for" actually is navigating you to the page for a new version. We have no way of knowing ahead of time whether the height of that page (mainly determined by the README) will be the same, and going to the top of the page makes the most sense for navigation.

However, the wording of that dropdown strongly implies that it only affects the download stats, rather than the entire page. I'm not sure whether the right answer is to reword that drop down, remove it, or change it to only affect download stats.

@carols10cents carols10cents added C-bug 🐞 Category: unintended, undesired behavior A-ui labels Jun 27, 2018
@locks locks self-assigned this Sep 7, 2019
@locks
Copy link
Contributor

locks commented Sep 12, 2019

Checking this issue out, I would also expect that the dropdown would select the version to display stats for, and not switch to a different version of the same crate.

My proposal would be to either remove the dropdown, or make it so that the dropdown only toggles the stats, which could be confusing for other reasons.

@sgrif
Copy link
Contributor

sgrif commented Sep 18, 2019

Either solution sounds fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend 🐹 C-bug 🐞 Category: unintended, undesired behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants