Auto merge of #2190 - JohnTitor:version-authors-user-id, r=jtgeibel

Remove unused `version_authors.user_id`

Fixes #2056

r? `@carols10cents`

Author: bors

migrations/2020-02-14-183929_remove_version_authors_user_id/down.sql

@@ -0,0 +1 @@
+ALTER TABLE version_authors ADD COLUMN user_id INTEGER;

migrations/2020-02-14-183929_remove_version_authors_user_id/up.sql

@@ -0,0 +1 @@
+ALTER TABLE version_authors DROP COLUMN user_id;

src/schema.patch

@@ -2,16 +2,13 @@ diff --git a/src/schema.rs b/src/schema.rs
 index df884e4..18e08cd 100644
 --- a/src/schema.rs
 +++ b/src/schema.rs
-@@ -1,5 +1,7 @@
+@@ -1,3 +1,5 @@
 +#![allow(unused_imports)]
 +
  table! {
      use diesel::sql_types::*;
      use diesel_full_text_search::{TsVector as Tsvector};
- 
-     /// Representation of the `api_tokens` table.
-@@ -125,14 +125,8 @@ table! {
-         /// Its SQL type is `Timestamp`.
+@@ -171,12 +173,6 @@
          ///
          /// (Automatically generated by Diesel.)
          created_at -> Timestamp,
@@ -23,12 +20,8 @@ index df884e4..18e08cd 100644
 -        path -> Ltree,
      }
  }
-
- table! {
-@@ -608,11 +610,29 @@ table! {
-         /// (Automatically generated by Diesel.)
-         rendered_at -> Timestamp,
-     }
+ 
+@@ -678,6 +674,24 @@
  }
 
  table! {
@@ -53,11 +46,7 @@ index df884e4..18e08cd 100644
      use diesel::sql_types::*;
      use diesel_full_text_search::{TsVector as Tsvector};
 
-     /// Representation of the `reserved_crate_names` table.
-     ///
-@@ -881,23 +901,25 @@ table! {
- 
- joinable!(api_tokens -> users (user_id));
+@@ -1003,7 +1017,8 @@
  joinable!(badges -> crates (crate_id));
  joinable!(crate_owner_invitations -> crates (crate_id));
  joinable!(crate_owners -> crates (crate_id));
@@ -67,33 +56,19 @@ index df884e4..18e08cd 100644
  joinable!(crates_categories -> categories (category_id));
  joinable!(crates_categories -> crates (crate_id));
  joinable!(crates_keywords -> crates (crate_id));
- joinable!(crates_keywords -> keywords (keyword_id));
- joinable!(dependencies -> crates (crate_id));
- joinable!(dependencies -> versions (version_id));
- joinable!(emails -> users (user_id));
- joinable!(follows -> crates (crate_id));
- joinable!(follows -> users (user_id));
+@@ -1016,6 +1031,7 @@
  joinable!(publish_limit_buckets -> users (user_id));
  joinable!(publish_rate_overrides -> users (user_id));
  joinable!(readme_renderings -> versions (version_id));
 +joinable!(recent_crate_downloads -> crates (crate_id));
- joinable!(version_authors -> users (user_id));
  joinable!(version_authors -> versions (version_id));
  joinable!(version_downloads -> versions (version_id));
- joinable!(version_owner_actions -> api_tokens (owner_token_id));
- 
-@@ -913,13 +935,14 @@ allow_tables_to_appear_in_same_query!(
-     emails,
-     follows,
-     keywords,
-     metadata,
+ joinable!(version_owner_actions -> api_tokens (api_token_id));
+@@ -1043,6 +1059,7 @@
      publish_limit_buckets,
      publish_rate_overrides,
      readme_renderings,
 +    recent_crate_downloads,
      reserved_crate_names,
      teams,
      users,
-     version_authors,
-     version_downloads,
-     versions,

src/schema.rs

@@ -834,12 +834,6 @@ table! {
         ///
         /// (Automatically generated by Diesel.)
         version_id -> Int4,
-        /// The `user_id` column of the `version_authors` table.
-        ///
-        /// Its SQL type is `Nullable<Int4>`.
-        ///
-        /// (Automatically generated by Diesel.)
-        user_id -> Nullable<Int4>,
         /// The `name` column of the `version_authors` table.
         ///
         /// Its SQL type is `Varchar`.
@@ -1056,7 +1050,6 @@ joinable!(publish_limit_buckets -> users (user_id));
 joinable!(publish_rate_overrides -> users (user_id));
 joinable!(readme_renderings -> versions (version_id));
 joinable!(recent_crate_downloads -> crates (crate_id));
-joinable!(version_authors -> users (user_id));
 joinable!(version_authors -> versions (version_id));
 joinable!(version_downloads -> versions (version_id));
 joinable!(version_owner_actions -> api_tokens (api_token_id));

src/tasks/dump_db/dump-db.toml

@@ -184,7 +184,6 @@ dependencies = ["versions"]
 [version_authors.columns]
 id = "public"
 version_id = "public"
-user_id = "private"
 name = "public"
 
 [version_downloads]