Auto merge of #2414 - Turbo87:props, r=locks

crate.version: Inline a few computed properties

It seems unnecessarily complicated in these cases to use computed properties for these values.

r? @locks

Author: bors

app/controllers/crate/version.js

@@ -22,18 +22,13 @@ export default Controller.extend({
   crate: alias('model.crate'),
   requestedVersion: alias('model.requestedVersion'),
   currentVersion: alias('model.version'),
-  crateTomlText: computed('crate.name', 'currentVersion.num', function () {
-    return `${this.get('crate.name')} = "${this.get('currentVersion.num')}"`;
-  }),
+
   keywords: alias('crate.keywords'),
   categories: alias('crate.categories'),
   badges: alias('crate.badges'),
   isOwner: computed('crate.owner_user', 'session.currentUser.id', function () {
     return this.get('crate.owner_user').findBy('id', this.get('session.currentUser.id'));
   }),
-  notYankedOrIsOwner: computed('currentVersion', 'crate.owner_user', 'session.currentUser.id', function () {
-    return !this.currentVersion.yanked || this.get('crate.owner_user').findBy('id', this.get('session.currentUser.id'));
-  }),
 
   sortedVersions: readOnly('crate.versions'),
 

app/templates/crate/version.hbs

@@ -51,9 +51,9 @@
     {{else}}
       <div local-class='install'>
         <div local-class='install-action'>Cargo.toml</div>
-        <code>{{ this.crateTomlText }}</code>
+        <code>{{this.crate.name}} = "{{this.currentVersion.num}}"</code>
         {{#if (is-clipboard-supported)}}
-          <CrateTomlCopy @copyText={{this.crateTomlText}} />
+          <CrateTomlCopy @copyText='{{this.crate.name}} = "{{this.currentVersion.num}}"' />
         {{/if}}
       </div>
       {{#if this.readme}}
@@ -70,7 +70,7 @@
       {{/if}}
     {{/if}}
   </div>
-  {{#if this.notYankedOrIsOwner}}
+  {{#if (or this.isOwner (not this.currentVersion.yanked))}}
     <section local-class='authorship' aria-label="Crate metadata">
       <div local-class='top'>
         <div>