Auto merge of #3431 - lf-:lint-fixes, r=Turbo87

Add labels to forms missing them

Author: bors

.template-lintrc.js

@@ -3,10 +3,5 @@
 module.exports = {
   extends: ['octane', 'a11y'],
 
-  pending: [
-    { moduleId: 'app/components/email-input', only: ['require-input-label'] },
-    { moduleId: 'app/components/header', only: ['no-duplicate-landmark-elements'] },
-    { moduleId: 'app/templates/catch-all', only: ['require-input-label'] },
-    { moduleId: 'app/components/settings/api-tokens', only: ['require-input-label'] },
-  ],
+  pending: [{ moduleId: 'app/components/header', only: ['no-duplicate-landmark-elements'] }],
 };

app/components/email-input.hbs

@@ -11,12 +11,13 @@
   {{#if this.isEditing }}
     <div local-class="row">
       <div local-class="label">
-        <dt>Email</dt>
+        <label for="email-input">Email</label>
       </div>
       <form local-class="email-form" {{on "submit" (prevent-default (perform this.saveEmailTask))}}>
         <Input
           @type="email"
           @value={{this.value}}
+          id="email-input"
           placeholder="Email"
           local-class="input"
           data-test-input

app/components/settings/api-tokens.hbs

@@ -30,6 +30,7 @@
         <Input
           @type="text"
           placeholder="New token name"
+          aria-label="New token name"
           disabled={{this.newToken.isSaving}}
           @value={{this.newToken.name}}
           data-test-focused-input

app/templates/catch-all.hbs

@@ -11,6 +11,7 @@
     @type="text"
     local-class="search-field"
     placeholder="Search"
+    aria-label="Search"
     @value={{this.header.searchValue}}
     required={{true}}
     data-test-404-search-input