Skip to content

Commit 9abe890

Browse files
Merge #956
956: Don't delete window.github_response, not allowed in strict mode r=carols10cents Instead, set it to undefined. Fixes #954.
2 parents 7545f47 + 61f63c8 commit 9abe890

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

app/routes/login.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ export default Route.extend({
1818
// ignore error
1919
}
2020

21-
delete window.github_response;
21+
window.github_response = undefined;
2222
let windowDimensions = [
2323
'width=1000',
2424
'height=450',
@@ -47,7 +47,7 @@ export default Route.extend({
4747
}
4848
window.clearInterval(oauthInterval);
4949
let json = window.github_response;
50-
delete window.github_response;
50+
window.github_response = undefined;
5151
if (!json) {
5252
return;
5353
}

0 commit comments

Comments
 (0)