Skip to content

Commit 7f81b26

Browse files
committed
Remove obsolete server_binary tests
The main purpose of these tests was to check that download requests are switching over to "unconditional redirects", but that mode has been the default for almost a year now and the API endpoint is no longer accessing the database. The secondary purpose was to check how the server behaves in unhealthy database conditions in general, but we already have the `unhealthy_database` tests module for that. These tests also rely on `env!("CARGO_BIN_EXE_server")`, which means that they have to be integration tests and can not be moved into the `crates_io` library itself. Since these tests rely on a few test utilities this means that all other test relying on these utilities also have to be integration tests to be able to share the code. tl;dr the tests are no longer particularly useful and enforce too many constraints on their surroundings
1 parent 97193cd commit 7f81b26

File tree

3 files changed

+0
-225
lines changed

3 files changed

+0
-225
lines changed

src/tests/all.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ mod read_only_mode;
3838
mod routes;
3939
mod schema_details;
4040
mod server;
41-
mod server_binary;
4241
mod team;
4342
mod token;
4443
mod unhealthy_database;

src/tests/server_binary.rs

Lines changed: 0 additions & 223 deletions
This file was deleted.

src/tests/util.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ mod mock_request;
4848
mod response;
4949
mod test_app;
5050

51-
pub(crate) use chaosproxy::ChaosProxy;
5251
use mock_request::MockRequest;
5352
pub use mock_request::MockRequestExt;
5453
pub use response::Response;

0 commit comments

Comments
 (0)