Skip to content

Commit 7ed8b8d

Browse files
committed
FlashMessage: Move flash-messages service dependency out of the component
... to make this a purely presentational component
1 parent 6acb22a commit 7ed8b8d

File tree

3 files changed

+2
-5
lines changed

3 files changed

+2
-5
lines changed

app/components/flash-message.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
11
import Component from '@ember/component';
2-
import { readOnly } from '@ember/object/computed';
3-
import { inject as service } from '@ember/service';
42

53
export default Component.extend({
6-
flashMessages: service(),
7-
message: readOnly('flashMessages.message'),
84
tagName: '',
95
});

app/controllers/application.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import { EKMixin, keyDown, keyPress } from 'ember-keyboard';
55
import { on } from '@ember/object/evented';
66

77
export default Controller.extend(EKMixin, {
8+
flashMessages: service(),
89
search: service(),
910
searchQuery: oneWay('search.q'),
1011
session: service(),

app/templates/application.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@
127127
</form>
128128

129129
<main id="main" class='inner-content'>
130-
<FlashMessage />
130+
<FlashMessage @message={{this.flashMessages.message}} />
131131

132132
{{outlet}}
133133
</main>

0 commit comments

Comments
 (0)