Auto merge of #3426 - Turbo87:bulk-fetch, r=jtgeibel

krate.search: Add support for `?ids[]=foo&ids[]=bar` queries

... to reduce unnecessary N+1 requests

This can be used in combination with e.g. #3405 to speed up the loading of crate descriptions.

Author: bors

src/controllers/krate/search.rs

@@ -168,6 +168,14 @@ pub fn search(req: &mut dyn RequestExt) -> EndpointResult {
                     .filter(follows::user_id.eq(user_id)),
             ),
         );
+    } else if params.get("ids[]").is_some() {
+        let query_bytes = req.query_string().unwrap_or("").as_bytes();
+        let ids: Vec<_> = url::form_urlencoded::parse(query_bytes)
+            .filter(|(key, _)| key == "ids[]")
+            .map(|(_, value)| value.to_string())
+            .collect();
+
+        query = query.filter(crates::name.eq(any(ids)));
     }
 
     if !include_yanked {

src/tests/krate/search.rs

@@ -403,6 +403,26 @@ fn exact_match_on_queries_with_sort() {
     assert_eq!(json.crates[3].name, "other_sort");
 }
 
+#[test]
+fn multiple_ids() {
+    let (app, anon, user) = TestApp::init().with_user();
+    let user = user.as_model();
+
+    app.db(|conn| {
+        CrateBuilder::new("foo", user.id).expect_build(conn);
+        CrateBuilder::new("bar", user.id).expect_build(conn);
+        CrateBuilder::new("baz", user.id).expect_build(conn);
+        CrateBuilder::new("other", user.id).expect_build(conn);
+    });
+
+    let json =
+        anon.search("ids%5B%5D=foo&ids%5B%5D=bar&ids%5B%5D=baz&ids%5B%5D=baz&ids%5B%5D=unknown");
+    assert_eq!(json.meta.total, 3);
+    assert_eq!(json.crates[0].name, "bar");
+    assert_eq!(json.crates[1].name, "baz");
+    assert_eq!(json.crates[2].name, "foo");
+}
+
 #[test]
 fn loose_search_order() {
     let (app, anon, user) = TestApp::init().with_user();