Auto merge of #1857 - hbina:fix_version_suggestion, r=locks

Fixed versions suggestion

Previously, if it had searched everything and found nothing. However, this also means it cannot find `maxVersion`, which was what it was set to before.
Thus, this commit's solution is to provide another fallback when there are no stable and non-yanked versions available. It will simply find anything that is not yet yanked even if it is unstable.
If even this fails, then we truly have nothing to offer thereby offering an empty page.

The code could be improved imo, but I am not especially well-versed in JavaScript.

Author: bors

app/routes/crate/version.js

@@ -43,14 +43,29 @@ export default Route.extend({
           .get('versions')
           .then(versions => {
             const latestStableVersion = versions.find(version => {
+              // Find the latest version that is stable AND not-yanked.
               if (!isUnstableVersion(version.get('num')) && !version.get('yanked')) {
                 return version;
               }
             });
 
             if (latestStableVersion == null) {
-              // If no stable version exists, fallback to `maxVersion`
-              params.version_num = maxVersion;
+              // Cannot find any version that is stable AND not-yanked.
+              // The fact that "maxVersion" itself cannot be found means that
+              // we have to fall back to the latest one that is unstable....
+              const latestUnyankedVersion = versions.find(version => {
+                // Find the latest version that is stable AND not-yanked.
+                if (!version.get('yanked')) {
+                  return version;
+                }
+              });
+
+              if (latestStableVersion == null) {
+                // There's not even any unyanked version...
+                params.version_num = maxVersion;
+              } else {
+                params.version_num = latestUnyankedVersion;
+              }
             } else {
               params.version_num = latestStableVersion.get('num');
             }