Skip to content

Commit 657d60b

Browse files
committed
Auto merge of #3404 - Turbo87:rev-deps-empty, r=pichfl
reverse-dependencies: Show "no results" message instead of empty list ### Before <img width="1159" alt="Bildschirmfoto 2021-03-13 um 00 24 57" src="https://user-images.githubusercontent.com/141300/111008935-8f71dd00-8392-11eb-891b-4fafbb31a0bc.png"> ### After <img width="1157" alt="Bildschirmfoto 2021-03-13 um 00 24 33" src="https://user-images.githubusercontent.com/141300/111008921-82ed8480-8392-11eb-9432-5ac8c7e5577b.png">
2 parents a704679 + 8537df8 commit 657d60b

File tree

2 files changed

+35
-24
lines changed

2 files changed

+35
-24
lines changed

app/styles/crate/reverse-dependencies.module.css

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,3 +42,8 @@
4242
.rev-dep-downloads {
4343
padding-left: 7px
4444
}
45+
46+
.no-results {
47+
text-align: center;
48+
margin: 20px;
49+
}
Lines changed: 30 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,35 @@
11
<CrateHeader @crate={{this.crate}} />
22

3-
<div local-class="results-meta">
4-
<ResultsCount
5-
@start={{this.pagination.currentPageStart}}
6-
@end={{this.pagination.currentPageEnd}}
7-
@total={{this.totalItems}}
8-
@name="reverse dependencies of {{this.crate.name}}"
9-
/>
10-
</div>
3+
{{#if this.model}}
4+
<div local-class="results-meta">
5+
<ResultsCount
6+
@start={{this.pagination.currentPageStart}}
7+
@end={{this.pagination.currentPageEnd}}
8+
@total={{this.totalItems}}
9+
@name="reverse dependencies of {{this.crate.name}}"
10+
/>
11+
</div>
1112

12-
<div local-class="list" data-test-list>
13-
{{#each this.model as |dependency index|}}
14-
<div local-class="row" data-test-row={{index}}>
15-
<div>
16-
<LinkTo @route="crate" @model={{dependency.version.crateName}} data-test-crate-name>
17-
{{dependency.version.crateName}}
18-
</LinkTo>
19-
requires {{dependency.req}}
13+
<div local-class="list" data-test-list>
14+
{{#each this.model as |dependency index|}}
15+
<div local-class="row" data-test-row={{index}}>
16+
<div>
17+
<LinkTo @route="crate" @model={{dependency.version.crateName}} data-test-crate-name>
18+
{{dependency.version.crateName}}
19+
</LinkTo>
20+
requires {{dependency.req}}
21+
</div>
22+
<div local-class="stats downloads">
23+
{{svg-jar "download-arrow" local-class="download-icon"}}
24+
<span local-class="rev-dep-downloads">{{ format-num dependency.downloads }}</span>
25+
</div>
2026
</div>
21-
<div local-class="stats downloads">
22-
{{svg-jar "download-arrow" local-class="download-icon"}}
23-
<span local-class="rev-dep-downloads">{{ format-num dependency.downloads }}</span>
24-
</div>
25-
</div>
26-
{{/each}}
27-
</div>
27+
{{/each}}
28+
</div>
2829

29-
<Pagination @pagination={{this.pagination}} />
30+
<Pagination @pagination={{this.pagination}} />
31+
{{else}}
32+
<div local-class="no-results">
33+
This crate is not used as a dependency in any other crate on crates.io.
34+
</div>
35+
{{/if}}

0 commit comments

Comments
 (0)