Auto merge of #1932 - jtgeibel:clippy-cleanups, r=carols10cents

Add `-D warnings` to `RUSTFLAGS` on CI

By denying warnings explicitly on CI, we don't need to deny warnings in each library or binary.  `#![warn(clippy::all)]` is used to automatically enable clippy in RLS enabled IDEs and `rust_2018_idioms` is now applied consistently.  Finally, clippy allow attributes that are no longer needed have been removed.

Author: bors

.travis.yml

@@ -21,7 +21,7 @@ env:
     - PERCY_PROJECT=crates-io/crates.io
     - PGPORT=5433
     - PATH=$HOME/.cargo/bin:$PATH
-    - RUSTFLAGS="-C debuginfo=0"
+    - RUSTFLAGS="-C debuginfo=0 -D warnings"
 
 install:
   - sudo cp /etc/postgresql/10/main/pg_hba.conf /etc/postgresql/11/main/pg_hba.conf

src/bin/background-worker.rs

@@ -10,7 +10,7 @@
 //! Usage:
 //!      cargo run --bin background-worker
 
-#![deny(warnings, clippy::all, rust_2018_idioms)]
+#![warn(clippy::all, rust_2018_idioms)]
 
 use cargo_registry::git::{Repository, RepositoryConfig};
 use cargo_registry::{background_jobs::*, db};

src/bin/delete-crate.rs

@@ -5,7 +5,7 @@
 // Usage:
 //      cargo run --bin delete-crate crate-name
 
-#![deny(warnings, clippy::all, rust_2018_idioms)]
+#![warn(clippy::all, rust_2018_idioms)]
 
 use cargo_registry::{db, models::Crate, schema::crates};
 use std::{

src/bin/delete-version.rs

@@ -5,7 +5,7 @@
 // Usage:
 //      cargo run --bin delete-version crate-name version-number
 
-#![deny(warnings, clippy::all, rust_2018_idioms)]
+#![warn(clippy::all, rust_2018_idioms)]
 
 use cargo_registry::{
     db,

src/bin/monitor.rs

@@ -4,7 +4,7 @@
 //! Usage:
 //!     cargo run --bin monitor
 
-#![deny(warnings, clippy::all, rust_2018_idioms)]
+#![warn(clippy::all, rust_2018_idioms)]
 
 mod on_call;
 

src/bin/populate.rs

@@ -4,7 +4,7 @@
 // Usage:
 //      cargo run --bin populate version_id1 version_id2 ...
 
-#![deny(warnings, clippy::all, rust_2018_idioms)]
+#![warn(clippy::all, rust_2018_idioms)]
 
 use cargo_registry::{db, schema::version_downloads};
 use std::env;

src/bin/render-readmes.rs

@@ -3,7 +3,7 @@
 //
 // Warning: this can take a lot of time.
 
-#![deny(warnings, clippy::all, rust_2018_idioms)]
+#![warn(clippy::all, rust_2018_idioms)]
 
 #[macro_use]
 extern crate serde;

src/bin/server.rs

@@ -1,4 +1,4 @@
-#![deny(warnings, clippy::all, rust_2018_idioms)]
+#![warn(clippy::all, rust_2018_idioms)]
 
 use cargo_registry::{boot, App, Env};
 use std::{

src/bin/test-pagerduty.rs

@@ -5,7 +5,7 @@
 //!
 //! Event type can be trigger, acknowledge, or resolve
 
-#![deny(warnings, clippy::all, rust_2018_idioms)]
+#![warn(clippy::all, rust_2018_idioms)]
 
 mod on_call;
 

src/bin/transfer-crates.rs

@@ -3,7 +3,7 @@
 // Usage:
 //      cargo run --bin transfer-crates from-user to-user
 
-#![deny(warnings, clippy::all, rust_2018_idioms)]
+#![warn(clippy::all, rust_2018_idioms)]
 
 use cargo_registry::{
     db,

src/email.rs

@@ -43,7 +43,6 @@ fn build_email(
         .map(|s| s.smtp_login.as_str())
         .unwrap_or("test@localhost");
 
-    #[allow(clippy::redundant_closure)]
     let email = Email::builder()
         .to(recipient)
         .from(sender)

src/lib.rs

@@ -3,10 +3,9 @@
 //! All implemented routes are defined in the [middleware](fn.middleware.html) function and
 //! implemented in the [category](category/index.html), [keyword](keyword/index.html),
 //! [krate](krate/index.html), [user](user/index.html) and [version](version/index.html) modules.
-#![deny(warnings, clippy::all, rust_2018_idioms)]
-#![deny(missing_debug_implementations, missing_copy_implementations)]
-#![deny(bare_trait_objects)]
-#![recursion_limit = "256"]
+
+#![warn(clippy::all, rust_2018_idioms)]
+#![warn(missing_debug_implementations, missing_copy_implementations)]
 
 #[macro_use]
 extern crate derive_deref;

src/models/version.rs

@@ -122,7 +122,6 @@ impl Version {
 }
 
 impl NewVersion {
-    #[allow(clippy::new_ret_no_self)]
     pub fn new(
         crate_id: i32,
         num: &semver::Version,

src/s3/lib.rs

@@ -1,4 +1,4 @@
-#![deny(warnings, clippy::all, rust_2018_idioms)]
+#![warn(clippy::all, rust_2018_idioms)]
 
 extern crate base64;
 extern crate chrono;

src/tests/all.rs

@@ -1,10 +1,4 @@
-#![deny(warnings, clippy::all, rust_2018_idioms)]
-// TODO: Remove after we can bump to Rust 1.35 stable in `RustConfig`
-#![allow(
-    renamed_and_removed_lints,
-    clippy::cyclomatic_complexity,
-    clippy::unknown_clippy_lints
-)]
+#![warn(clippy::all, rust_2018_idioms)]
 
 #[macro_use]
 extern crate diesel;

src/tests/krate.rs

@@ -1505,7 +1505,6 @@ fn yank_by_a_non_owner_fails() {
 }
 
 #[test]
-#[allow(clippy::cognitive_complexity)]
 fn yank_max_version() {
     let (_, anon, _, token) = TestApp::full().with_token();