Skip to content

Commit 520ef37

Browse files
committed
Update to ember-keyboard 6.0.0
- refactor to new template helpers
1 parent 0adb52f commit 520ef37

File tree

9 files changed

+203
-1147
lines changed

9 files changed

+203
-1147
lines changed

app/components/dropdown.hbs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
local-class="container"
33
...attributes
44
{{on-click-outside (action (mut this.dropdownExpanded) false)}}
5+
{{on-key 'Escape' (action (mut this.dropdownExpanded) false)}}
56
>
67
{{yield (hash
78
Trigger=(component "dropdown/trigger" toggle=(action "toggleDropdown"))

app/components/dropdown.js

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,10 @@
11
import Component from '@ember/component';
2-
import { on } from '@ember/object/evented';
32

4-
import { EKMixin, EKOnInsertMixin, keyDown } from 'ember-keyboard';
5-
6-
export default Component.extend(EKMixin, EKOnInsertMixin, {
3+
export default Component.extend({
74
tagName: '',
85

96
dropdownExpanded: false,
107

11-
onEscape: on(keyDown('Escape'), function () {
12-
this.set('dropdownExpanded', false);
13-
}),
14-
158
actions: {
169
toggleDropdown() {
1710
this.toggleProperty('dropdownExpanded');

app/components/header.hbs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@
2222
data-test-search-input
2323
>
2424
<label for="cargo-desktop-search" local-class="search-label">Search</label>
25+
{{on-key 's' (focus '#cargo-desktop-search')}}
26+
{{on-key 'shift+s' (focus '#cargo-desktop-search')}}
2527
</form>
2628

2729
<nav local-class='nav'>

app/components/header.js

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,13 @@
11
import Component from '@ember/component';
2-
import { on } from '@ember/object/evented';
32
import { inject as service } from '@ember/service';
43

5-
import { EKMixin, keyDown, keyPress } from 'ember-keyboard';
6-
7-
export default Component.extend(EKMixin, {
4+
export default Component.extend({
85
header: service(),
96
router: service(),
107
session: service(),
118

129
tagName: '',
1310

14-
keyboardActivated: true,
15-
16-
focusSearch: on(keyDown('KeyS'), keyPress('KeyS'), keyDown('shift+KeyS'), function (event) {
17-
if (event.ctrlKey || event.altKey || event.metaKey) {
18-
return;
19-
}
20-
21-
if (document.activeElement === document.body) {
22-
event.preventDefault();
23-
document.querySelector('#cargo-desktop-search').focus();
24-
}
25-
}),
26-
2711
actions: {
2812
search(event) {
2913
event.preventDefault();

app/helpers/focus.js

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
import { helper } from '@ember/component/helper';
2+
3+
export function focus([selector]) {
4+
return function (event) {
5+
if (document.activeElement === document.body) {
6+
event.preventDefault();
7+
document.querySelector(selector).focus();
8+
}
9+
};
10+
}
11+
12+
export default helper(focus);

config/environment.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,9 @@ module.exports = function (environment) {
3030
'ember-cli-mirage': {
3131
discoverEmberDataModels: false,
3232
},
33+
emberKeyboard: {
34+
disableInputsInitializer: true,
35+
},
3336
};
3437

3538
if (environment === 'development') {

0 commit comments

Comments
 (0)