A handful of cleanups

Author: wycats

app/controllers/crate/index.js

@@ -28,6 +28,14 @@ export default Ember.ObjectController.extend({
         return this.get("sortedVersions.length") > NUM_VERSIONS;
     }.property('sortedVersions'),
 
+    anyLinks: function() {
+      return this.get('homepage') ||
+             this.get('wiki') ||
+             this.get('mailing_list') ||
+             this.get('documentation') ||
+             this.get('repository');
+    }.property('homepage', 'wiki', 'mailing_list', 'documentation', 'repository'),
+
     displayedAuthors: function() {
         var self = this;
         if (!this.get('currentVersion')) {

app/helpers/format-email.js

@@ -0,0 +1,19 @@
+import Ember from "ember";
+
+var escape = Ember.Handlebars.Utils.escapeExpression;
+
+function formatEmail(email) {
+  var formatted = email.match(/^(.*?)\s*(?:<(.*)>)?$/);
+  var email = "";
+
+  email += escape(formatted[1]);
+
+  if (formatted[2]) {
+    email = "<a href='mailto:" + escape(formatted[2]) + "'>" + email + "</a>";
+  }
+
+  console.log(email);
+  return email.htmlSafe();
+}
+
+export default Ember.Handlebars.makeBoundHelper(formatEmail);

app/helpers/format-req.js

@@ -0,0 +1,7 @@
+import Ember from "ember";
+
+function formatReq(req) {
+  return req === "*" ? "" : req;
+}
+
+export default Ember.Handlebars.makeBoundHelper(formatReq);

app/styles/crate.scss

@@ -152,6 +152,10 @@
             .top, .bottom {
                 @include flex-direction(column);
             }
+
+            ul {
+              padding-left: 20px;
+            }
         }
     }
 

app/templates/crate/index.hbs

@@ -48,7 +48,7 @@
             </div>
         {{/if}}
         <div class='install'>
-            <div class='action'>Depend</div>
+            <div class='action'>Cargo.toml</div>
             <code>{{ name }} = "~{{ currentVersion.num }}"</code>
         </div>
     </div>
@@ -59,11 +59,11 @@
                 <div class='date'>{{ from-now updated_at }}</div>
             </div>
 
-            <div>
+            <div class="authors">
                 <h3>Authors</h3>
                 <ul>
                     {{#each displayedAuthors}}
-                        <li>{{ name }}</li>
+                        <li>{{ format-email name }}</li>
                     {{/each}}
                 </ul>
             </div>
@@ -107,6 +107,7 @@
 </div>
 
 <div id='crate-links'>
+  {{#if anyLinks}}
   <div class='section'>
     <h3>Links</h3>
     <ul>
@@ -127,32 +128,37 @@
       {{/if}}
     </ul>
   </div>
+  {{/if}}
 
   <div class='section' id='crate-dependencies'>
     <h3>Dependencies</h3>
     <ul>
       {{#each currentDependencies}}
       <li>
         {{#link-to 'crate' crate_id}}
-        {{ crate_id}} {{ req }}
+        {{ crate_id }} {{ format-req req }}
         {{/link-to}}
       </li>
+      {{else}}
+      <li>None</li>
       {{/each}}
     </ul>
   </div>
 
-  <div class='section' id='crate-dev-dependencies'>
-    <h3>Dev-Dependencies</h3>
-    <ul>
-      {{#each currentDevDependencies}}
-      <li>
-        {{#link-to 'crate' crate_id}}
-        {{ crate_id}} {{ req }}
-        {{/link-to}}
-      </li>
-      {{/each}}
-    </ul>
-  </div>
+  {{#if currentDevDependencies}}
+    <div class='section' id='crate-dev-dependencies'>
+      <h3>Dev-Dependencies</h3>
+      <ul>
+        {{#each currentDevDependencies}}
+        <li>
+          {{#link-to 'crate' crate_id}}
+          {{ crate_id}} {{ req }}
+          {{/link-to}}
+        </li>
+        {{/each}}
+      </ul>
+    </div>
+  {{/if}}
 
   <div class='section' id='crate-versions'>
     <h3>Versions</h3>

app/templates/loading.hbs

@@ -0,0 +1 @@
+Loading...