Skip to content

Commit 3b35041

Browse files
committed
src: Add back-referencing comments to route handler functions
These comments should be further extended with input/output definitions and examples
1 parent df3b918 commit 3b35041

File tree

4 files changed

+30
-1
lines changed

4 files changed

+30
-1
lines changed

src/keyword.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,7 @@ impl Model for Keyword {
139139
fn table_name(_: Option<Keyword>) -> &'static str { "keywords" }
140140
}
141141

142+
/// Handles the `GET /keywords` route.
142143
pub fn index(req: &mut Request) -> CargoResult<Response> {
143144
let conn = try!(req.tx());
144145
let (offset, limit) = try!(req.pagination(10, 100));
@@ -175,6 +176,7 @@ pub fn index(req: &mut Request) -> CargoResult<Response> {
175176
}))
176177
}
177178

179+
/// Handles the `GET /keywords/:keyword_id` route.
178180
pub fn show(req: &mut Request) -> CargoResult<Response> {
179181
let name = &req.params()["keyword_id"];
180182
let conn = try!(req.tx());
@@ -185,4 +187,3 @@ pub fn show(req: &mut Request) -> CargoResult<Response> {
185187
struct R { keyword: EncodableKeyword }
186188
Ok(req.json(&R { keyword: kw.encodable() }))
187189
}
188-

src/krate.rs

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -452,6 +452,7 @@ impl Model for Crate {
452452
fn table_name(_: Option<Crate>) -> &'static str { "crates" }
453453
}
454454

455+
/// Handles the `GET /crates` route.
455456
#[allow(trivial_casts)]
456457
pub fn index(req: &mut Request) -> CargoResult<Response> {
457458
let conn = try!(req.tx());
@@ -574,6 +575,7 @@ pub fn index(req: &mut Request) -> CargoResult<Response> {
574575
}))
575576
}
576577

578+
/// Handles the `GET /summary` route.
577579
pub fn summary(req: &mut Request) -> CargoResult<Response> {
578580
let tx = try!(req.tx());
579581
let num_crates = {
@@ -620,6 +622,7 @@ pub fn summary(req: &mut Request) -> CargoResult<Response> {
620622
}))
621623
}
622624

625+
/// Handles the `GET /crates/:crate_id` route.
623626
pub fn show(req: &mut Request) -> CargoResult<Response> {
624627
let name = &req.params()["crate_id"];
625628
let conn = try!(req.tx());
@@ -643,6 +646,7 @@ pub fn show(req: &mut Request) -> CargoResult<Response> {
643646
}))
644647
}
645648

649+
/// Handles the `PUT /crates/new` route.
646650
pub fn new(req: &mut Request) -> CargoResult<Response> {
647651
let app = req.app().clone();
648652

@@ -817,6 +821,7 @@ fn read_fill<R: Read + ?Sized>(r: &mut R, mut slice: &mut [u8])
817821
Ok(())
818822
}
819823

824+
/// Handles the `GET /crates/:crate_id/:version/download` route.
820825
pub fn download(req: &mut Request) -> CargoResult<Response> {
821826
let crate_name = &req.params()["crate_id"];
822827
let version = &req.params()["version"];
@@ -872,6 +877,7 @@ pub fn download(req: &mut Request) -> CargoResult<Response> {
872877
}
873878
}
874879

880+
/// Handles the `GET /crates/:crate_id/downloads` route.
875881
pub fn downloads(req: &mut Request) -> CargoResult<Response> {
876882
let crate_name = &req.params()["crate_id"];
877883
let tx = try!(req.tx());
@@ -931,6 +937,7 @@ fn user_and_crate(req: &mut Request) -> CargoResult<(User, Crate)> {
931937
Ok((user.clone(), krate))
932938
}
933939

940+
/// Handles the `PUT /crates/:crate_id/follow` route.
934941
pub fn follow(req: &mut Request) -> CargoResult<Response> {
935942
let (user, krate) = try!(user_and_crate(req));
936943
let tx = try!(req.tx());
@@ -946,6 +953,7 @@ pub fn follow(req: &mut Request) -> CargoResult<Response> {
946953
Ok(req.json(&R { ok: true }))
947954
}
948955

956+
/// Handles the `DELETE /crates/:crate_id/follow` route.
949957
pub fn unfollow(req: &mut Request) -> CargoResult<Response> {
950958
let (user, krate) = try!(user_and_crate(req));
951959
let tx = try!(req.tx());
@@ -957,6 +965,7 @@ pub fn unfollow(req: &mut Request) -> CargoResult<Response> {
957965
Ok(req.json(&R { ok: true }))
958966
}
959967

968+
/// Handles the `GET /crates/:crate_id/following` route.
960969
pub fn following(req: &mut Request) -> CargoResult<Response> {
961970
let (user, krate) = try!(user_and_crate(req));
962971
let tx = try!(req.tx());
@@ -968,6 +977,7 @@ pub fn following(req: &mut Request) -> CargoResult<Response> {
968977
Ok(req.json(&R { following: rows.next().is_some() }))
969978
}
970979

980+
/// Handles the `GET /crates/:crate_id/versions` route.
971981
pub fn versions(req: &mut Request) -> CargoResult<Response> {
972982
let crate_name = &req.params()["crate_id"];
973983
let tx = try!(req.tx());
@@ -981,6 +991,7 @@ pub fn versions(req: &mut Request) -> CargoResult<Response> {
981991
Ok(req.json(&R{ versions: versions }))
982992
}
983993

994+
/// Handles the `GET /crates/:crate_id/owners` route.
984995
pub fn owners(req: &mut Request) -> CargoResult<Response> {
985996
let crate_name = &req.params()["crate_id"];
986997
let tx = try!(req.tx());
@@ -993,10 +1004,12 @@ pub fn owners(req: &mut Request) -> CargoResult<Response> {
9931004
Ok(req.json(&R{ users: owners }))
9941005
}
9951006

1007+
/// Handles the `PUT /crates/:crate_id/owners` route.
9961008
pub fn add_owners(req: &mut Request) -> CargoResult<Response> {
9971009
modify_owners(req, true)
9981010
}
9991011

1012+
/// Handles the `DELETE /crates/:crate_id/owners` route.
10001013
pub fn remove_owners(req: &mut Request) -> CargoResult<Response> {
10011014
modify_owners(req, false)
10021015
}
@@ -1054,6 +1067,7 @@ fn modify_owners(req: &mut Request, add: bool) -> CargoResult<Response> {
10541067
Ok(req.json(&R{ ok: true }))
10551068
}
10561069

1070+
/// Handles the `GET /crates/:crate_id/reverse_dependencies` route.
10571071
pub fn reverse_dependencies(req: &mut Request) -> CargoResult<Response> {
10581072
let name = &req.params()["crate_id"];
10591073
let conn = try!(req.tx());

src/user/mod.rs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,9 @@ impl Model for User {
136136
fn table_name(_: Option<User>) -> &'static str { "users" }
137137
}
138138

139+
/// Handles the `GET /authorize_url` route.
139140
pub fn github_authorize(req: &mut Request) -> CargoResult<Response> {
141+
// Generate a random 16 char ASCII string
140142
let state: String = thread_rng().gen_ascii_chars().take(16).collect();
141143
req.session().insert("github_oauth_state".to_string(), state.clone());
142144

@@ -147,6 +149,7 @@ pub fn github_authorize(req: &mut Request) -> CargoResult<Response> {
147149
Ok(req.json(&R { url: url.to_string(), state: state }))
148150
}
149151

152+
/// Handles the `GET /authorize` route.
150153
pub fn github_access_token(req: &mut Request) -> CargoResult<Response> {
151154
// Parse the url query
152155
let mut query = req.query();
@@ -197,11 +200,13 @@ pub fn github_access_token(req: &mut Request) -> CargoResult<Response> {
197200
me(req)
198201
}
199202

203+
/// Handles the `GET /logout` route.
200204
pub fn logout(req: &mut Request) -> CargoResult<Response> {
201205
req.session().remove(&"user_id".to_string());
202206
Ok(req.json(&true))
203207
}
204208

209+
/// Handles the `GET /me/reset_token` route.
205210
pub fn reset_token(req: &mut Request) -> CargoResult<Response> {
206211
let user = try!(req.user());
207212

@@ -215,6 +220,7 @@ pub fn reset_token(req: &mut Request) -> CargoResult<Response> {
215220
Ok(req.json(&R { api_token: token }))
216221
}
217222

223+
/// Handles the `GET /me` route.
218224
pub fn me(req: &mut Request) -> CargoResult<Response> {
219225
let user = try!(req.user());
220226

@@ -224,6 +230,7 @@ pub fn me(req: &mut Request) -> CargoResult<Response> {
224230
Ok(req.json(&R{ user: user.clone().encodable(), api_token: token }))
225231
}
226232

233+
/// Handles the `GET /me/updates` route.
227234
pub fn updates(req: &mut Request) -> CargoResult<Response> {
228235
let user = try!(req.user());
229236
let (offset, limit) = try!(req.pagination(10, 100));

src/version.rs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -210,6 +210,7 @@ impl Model for Version {
210210
fn table_name(_: Option<Version>) -> &'static str { "versions" }
211211
}
212212

213+
/// Handles the `GET /versions` route.
213214
pub fn index(req: &mut Request) -> CargoResult<Response> {
214215
let conn = try!(req.tx());
215216

@@ -247,6 +248,7 @@ pub fn index(req: &mut Request) -> CargoResult<Response> {
247248
Ok(req.json(&R { versions: versions }))
248249
}
249250

251+
/// Handles the `GET /versions/:version_id` route.
250252
pub fn show(req: &mut Request) -> CargoResult<Response> {
251253
let (version, krate) = match req.params().find("crate_id") {
252254
Some(..) => try!(version_and_crate(req)),
@@ -281,6 +283,7 @@ fn version_and_crate(req: &mut Request) -> CargoResult<(Version, Crate)> {
281283
Ok((version, krate))
282284
}
283285

286+
/// Handles the `GET /crates/:crate_id/:version/dependencies` route.
284287
pub fn dependencies(req: &mut Request) -> CargoResult<Response> {
285288
let (version, _) = try!(version_and_crate(req));
286289
let tx = try!(req.tx());
@@ -294,6 +297,7 @@ pub fn dependencies(req: &mut Request) -> CargoResult<Response> {
294297
Ok(req.json(&R{ dependencies: deps }))
295298
}
296299

300+
/// Handles the `GET /crates/:crate_id/:version/downloads` route.
297301
pub fn downloads(req: &mut Request) -> CargoResult<Response> {
298302
let (version, _) = try!(version_and_crate(req));
299303

@@ -313,6 +317,7 @@ pub fn downloads(req: &mut Request) -> CargoResult<Response> {
313317
Ok(req.json(&R{ version_downloads: downloads }))
314318
}
315319

320+
/// Handles the `GET /crates/:crate_id/:version/authors` route.
316321
pub fn authors(req: &mut Request) -> CargoResult<Response> {
317322
let (version, _) = try!(version_and_crate(req));
318323
let tx = try!(req.tx());
@@ -331,10 +336,12 @@ pub fn authors(req: &mut Request) -> CargoResult<Response> {
331336
Ok(req.json(&R{ users: users, meta: Meta { names: names } }))
332337
}
333338

339+
/// Handles the `DELETE /crates/:crate_id/:version/yank` route.
334340
pub fn yank(req: &mut Request) -> CargoResult<Response> {
335341
modify_yank(req, true)
336342
}
337343

344+
/// Handles the `PUT /crates/:crate_id/:version/unyank` route.
338345
pub fn unyank(req: &mut Request) -> CargoResult<Response> {
339346
modify_yank(req, false)
340347
}

0 commit comments

Comments
 (0)