Redirect /owners to /settings

fix typo

fix

test: add cases

test: add cases

Author: 0xPoe

app/controllers/crate/owners.js renamed to app/controllers/crate/settings.js

@@ -3,7 +3,7 @@ import { inject as service } from '@ember/service';
 
 import { task } from 'ember-concurrency';
 
-export default class CrateOwnersController extends Controller {
+export default class CrateSettingsController extends Controller {
   @service notifications;
 
   crate = null;

app/router.js

@@ -20,6 +20,7 @@ Router.map(function () {
     this.route('reverse-dependencies', { path: 'reverse_dependencies' });
 
     this.route('owners');
+    this.route('settings');
 
     // Well-known routes
     this.route('docs');

app/routes/crate/owners.js

@@ -1,9 +1,9 @@
 import Route from '@ember/routing/route';
 
 export default class OwnersRoute extends Route {
-  setupController(controller) {
-    super.setupController(...arguments);
+  redirect() {
     let crate = this.modelFor('crate');
-    controller.set('crate', crate);
+
+    this.transitionTo('crate.settings', crate);
   }
 }

app/routes/crate/settings.js

@@ -0,0 +1,9 @@
+import Route from '@ember/routing/route';
+
+export default class SettingsRoute extends Route {
+  setupController(controller) {
+    super.setupController(...arguments);
+    let crate = this.modelFor('crate');
+    controller.set('crate', crate);
+  }
+}

app/styles/crate/owners.module.css renamed to app/styles/crate/settings.module.css

@@ -1,4 +1,4 @@
-{{page-title 'Manage Crate Owners'}}
+{{page-title 'Manage Crate Settings'}}
 
 <CrateHeader @crate={{this.crate}} />
 

app/templates/crate/owners.hbs renamed to app/templates/crate/settings.hbs

@@ -201,7 +201,7 @@ module('Acceptance | crate page', function (hooks) {
     assert.dom('[data-test-settings-tab]').doesNotExist();
   });
 
-  test('navigating to the owners page', async function (assert) {
+  test('navigating to the settings page', async function (assert) {
     this.server.loadFixtures();
 
     let user = this.server.schema.users.findBy({ login: 'thehydroimpulse' });
@@ -210,6 +210,6 @@ module('Acceptance | crate page', function (hooks) {
     await visit('/crates/nanomsg');
     await click('[data-test-settings-tab] a');
 
-    assert.equal(currentURL(), '/crates/nanomsg/owners');
+    assert.equal(currentURL(), '/crates/nanomsg/settings');
   });
 });

tests/acceptance/crate-test.js

@@ -8,12 +8,28 @@ import { setupApplicationTest } from 'cargo/tests/helpers';
 
 import axeConfig from '../axe-config';
 
-module('Acceptance | /crates/:name/owners', function (hooks) {
+module('Acceptance | /crates/:name/settings', function (hooks) {
   setupApplicationTest(hooks);
 
   test('listing crate owners', async function (assert) {
     this.server.loadFixtures();
 
+    await visit('/crates/nanomsg/settings');
+
+    assert.dom('[data-test-owners] [data-test-owner-team]').exists({ count: 2 });
+    assert.dom('[data-test-owners] [data-test-owner-user]').exists({ count: 2 });
+    assert.dom('a[href="/teams/github:org:thehydroimpulse"]').exists();
+    assert.dom('a[href="/teams/github:org:blabaere"]').exists();
+    assert.dom('a[href="/users/thehydroimpulse"]').exists();
+    assert.dom('a[href="/users/blabaere"]').exists();
+
+    await percySnapshot(assert);
+    await a11yAudit(axeConfig);
+  });
+
+  test('redirecting and listing crate owners', async function (assert) {
+    this.server.loadFixtures();
+
     await visit('/crates/nanomsg/owners');
 
     assert.dom('[data-test-owners] [data-test-owner-team]').exists({ count: 2 });
@@ -30,15 +46,15 @@ module('Acceptance | /crates/:name/owners', function (hooks) {
   test('attempting to add owner without username', async function (assert) {
     this.server.loadFixtures();
 
-    await visit('/crates/nanomsg/owners');
+    await visit('/crates/nanomsg/settings');
     await fillIn('input[name="username"]', '');
     assert.dom('[data-test-save-button]').isDisabled();
   });
 
   test('attempting to add non-existent owner', async function (assert) {
     this.server.loadFixtures();
 
-    await visit('/crates/nanomsg/owners');
+    await visit('/crates/nanomsg/settings');
     await fillIn('input[name="username"]', 'spookyghostboo');
     await click('[data-test-save-button]');
 
@@ -52,7 +68,7 @@ module('Acceptance | /crates/:name/owners', function (hooks) {
   test('add a new owner', async function (assert) {
     this.server.loadFixtures();
 
-    await visit('/crates/nanomsg/owners');
+    await visit('/crates/nanomsg/settings');
     await fillIn('input[name="username"]', 'iain8');
     await click('[data-test-save-button]');
 
@@ -64,7 +80,7 @@ module('Acceptance | /crates/:name/owners', function (hooks) {
   test('remove a crate owner when owner is a user', async function (assert) {
     this.server.loadFixtures();
 
-    await visit('/crates/nanomsg/owners');
+    await visit('/crates/nanomsg/settings');
     await click('[data-test-owner-user="thehydroimpulse"] [data-test-remove-owner-button]');
 
     assert.dom('[data-test-notification-message="success"]').hasText('User thehydroimpulse removed as crate owner');
@@ -86,7 +102,7 @@ module('Acceptance | /crates/:name/owners', function (hooks) {
 
     this.authenticateAs(user);
 
-    await visit(`/crates/${crate.name}/owners`);
+    await visit(`/crates/${crate.name}/settings`);
     await click(`[data-test-owner-user="${user2.login}"] [data-test-remove-owner-button]`);
 
     assert
@@ -98,7 +114,7 @@ module('Acceptance | /crates/:name/owners', function (hooks) {
   test('remove a crate owner when owner is a team', async function (assert) {
     this.server.loadFixtures();
 
-    await visit('/crates/nanomsg/owners');
+    await visit('/crates/nanomsg/settings');
     await click('[data-test-owner-team="github:org:thehydroimpulse"] [data-test-remove-owner-button]');
 
     assert
@@ -122,7 +138,7 @@ module('Acceptance | /crates/:name/owners', function (hooks) {
 
     this.authenticateAs(user);
 
-    await visit(`/crates/${crate.name}/owners`);
+    await visit(`/crates/${crate.name}/settings`);
     await click(`[data-test-owner-team="${team.login}"] [data-test-remove-owner-button]`);
 
     assert