Auto merge of #2041 - Turbo87:button, r=locks

template-lint: Enable `require-button-type` rule

see https://github.com/ember-template-lint/ember-template-lint/blob/master/docs/rule/require-button-type.md

r? @locks @NullVoxPopuli

Author: bors

.template-lintrc.js

@@ -13,6 +13,5 @@ module.exports = {
     'no-implicit-this': false,
     'no-unnecessary-concat': false,
     quotes: false,
-    'require-button-type': false,
   },
 };

app/templates/components/api-token-row.hbs

@@ -39,16 +39,22 @@
 
   <div class='actions'>
     {{#if api_token.isNew}}
-      <button class='small yellow-button'
-          disabled={{disableCreate}}
-          title={{if emptyName "You must specify a name" ""}}
-          {{action "saveToken"}}>
+      <button
+        type="button"
+        class='small yellow-button'
+        disabled={{disableCreate}}
+        title={{if emptyName "You must specify a name" ""}}
+        {{action "saveToken"}}
+      >
         Create
       </button>
     {{else}}
-      <button class='small tan-button'
-          disabled={{api_token.isSaving}}
-          {{action "revokeToken"}}>
+      <button
+        type="button"
+        class='small tan-button'
+        disabled={{api_token.isSaving}}
+        {{action "revokeToken"}}
+      >
         Revoke
       </button>
     {{/if}}

app/templates/components/email-input.hbs

@@ -21,7 +21,7 @@
       {{/if}}
       <div class='actions'>
         <button type='submit' class='small yellow-button space-right' disabled={{disableSave}}>Save</button>
-        <button class='small yellow-button' {{action 'cancelEdit'}}>Cancel</button>
+        <button type="button" class='small yellow-button' {{action 'cancelEdit'}}>Cancel</button>
       </div>
     </form>
   </div>
@@ -39,7 +39,7 @@
       </dd>
     </div>
     <div class='actions'>
-      <button class='small yellow-button space-left' {{action 'editEmail'}}>Edit</button>
+      <button type="button" class='small yellow-button space-left' {{action 'editEmail'}}>Edit</button>
     </div>
   </div>
   {{#if emailNotVerified }}
@@ -51,7 +51,9 @@
         <p class='small-text'>Your email has not yet been verified.</p>
       </div>
       <div class='actions'>
-        <button class='small yellow-button space-left' {{action 'resendEmail'}} disabled={{disableResend}}>{{resendButtonText}}</button>
+        <button type="button" class='small yellow-button space-left' {{action 'resendEmail'}} disabled={{disableResend}}>
+          {{resendButtonText}}
+        </button>
       </div>
     </div>
   {{/if}}

app/templates/components/pending-owner-invite-row.hbs

@@ -30,8 +30,8 @@
         <span class='small'>{{moment-from-now invite.created_at}}</span>
       </div>
       <div class='actions'>
-        <button class='small yellow-button' {{action 'acceptInvitation' invite}}>Accept</button>
-        <button class='small yellow-button' {{action 'declineInvitation' invite}}>Decline</button>
+        <button type="button" class='small yellow-button' {{action 'acceptInvitation' invite}}>Accept</button>
+        <button type="button" class='small yellow-button' {{action 'declineInvitation' invite}}>Decline</button>
       </div>
       {{#if isError}}
         <div class='label'>

app/templates/crate/owners.hbs

@@ -64,7 +64,7 @@
         {{/if}}
       </div>
       <div class='stats downloads'>
-        <button class='remove-owner small yellow-button' {{action 'removeOwner' user}}>Remove</button>
+        <button type="button" class='remove-owner small yellow-button' {{action 'removeOwner' user}}>Remove</button>
       </div>
     </div>
   {{/each}}

app/templates/crate/version.hbs

@@ -10,7 +10,7 @@
 
     <div class='right'>
       {{#if session.currentUser}}
-        <button class='tan-button' {{action 'toggleFollow' this}}>
+        <button type="button" class='tan-button' {{action 'toggleFollow' this}}>
           {{#if fetchingFollowing}}
             <img src="/assets/ajax-loader.gif">
           {{else}}

app/templates/dashboard.hbs

@@ -74,7 +74,7 @@
         </span>
       {{else}}
         {{#if hasMore}}
-          <button class='load-more' {{ action 'loadMore' }}>
+          <button type="button" class='load-more' {{ action 'loadMore' }}>
             Load More
           </button>
         {{/if}}

app/templates/me/index.hbs

@@ -72,7 +72,7 @@
   <div class='me-subheading'>
     <h2>API Access</h2>
     <div class='right'>
-      <button class='yellow-button' disabled={{disableCreate}} {{action "startNewToken"}}>New Token</button>
+      <button type="button" class='yellow-button' disabled={{disableCreate}} {{action "startNewToken"}}>New Token</button>
     </div>
   </div>