Show generic flash message if crate data fails to load

Rethrowing the error means that it ends up creating noise on Sentry even for regular network errors.

Author: Turbo87

app/routes/crate.js

@@ -10,10 +10,11 @@ export default class CrateRoute extends Route {
     } catch (error) {
       if (error.errors?.some(e => e.detail === 'Not Found')) {
         this.notifications.error(`Crate '${params.crate_id}' does not exist`);
-        this.replaceWith('index');
       } else {
-        throw error;
+        this.notifications.error(`Loading data for the '${params.crate_id}' crate failed. Please try again later!`);
       }
+
+      this.replaceWith('index');
     }
   }
 

tests/acceptance/crate-test.js

@@ -87,6 +87,16 @@ module('Acceptance | crate page', function (hooks) {
     assert.dom('[data-test-notification-message]').hasText("Crate 'nanomsg' does not exist");
   });
 
+  test('other crate loading error shows an error message', async function (assert) {
+    this.server.get('/api/v1/crates/:crate_name', {}, 500);
+
+    await visit('/crates/nanomsg');
+    assert.equal(currentURL(), '/');
+    assert
+      .dom('[data-test-notification-message]')
+      .hasText("Loading data for the 'nanomsg' crate failed. Please try again later!");
+  });
+
   test('unknown versions fall back to latest version and show an error message', async function (assert) {
     this.server.create('crate', { name: 'nanomsg' });
     this.server.create('version', { crateId: 'nanomsg', num: '0.6.0' });