Skip to content

Add --json=timings option to print build timings #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 3 tasks
Kobzol opened this issue May 17, 2025 · 3 comments
Closed
1 of 3 tasks

Add --json=timings option to print build timings #873

Kobzol opened this issue May 17, 2025 · 3 comments
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@Kobzol
Copy link
Contributor

Kobzol commented May 17, 2025

Proposal

I would like to add new a option to the --json compiler flag, called e.g. timings, which would print a JSON message with a very high-level overview of the time spent in individual sections of the compilation (e.g. frontend/backend/debuginfo generation/linking). This information could be then processed e.g. by Cargo and displayed in cargo build --timings (rust-lang/cargo#14265, rust-lang/cargo#10643), to help Rust users more easily diagnose where is the bottleneck in their compilation pipeline.

In terms of implementation, I'm imagining a very slimmed down version of -Zself-profile that is very cheap. Essentially just wrap the frontend/backend/linker sections of the compiler and output their wall-time duration.

Mentors or Reviewers

@Mark-Simulacrum

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

@Kobzol Kobzol added T-compiler Add this label so rfcbot knows to poll the compiler team major-change A proposal to make a major change to rustc labels May 17, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 17, 2025

Important

This issue is not meant to be used for technical discussion. There is a Zulip stream for that.
Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

Concerns or objections can formally be registered here by adding a comment.

@rfcbot concern reason-for-concern
<description of the concern>

Concerns can be lifted with:

@rfcbot resolve reason-for-concern

See documentation at https://forge.rust-lang.org

cc @rust-lang/compiler

@rustbot rustbot added the to-announce Announce this issue on triage meeting label May 17, 2025
@davidtwco
Copy link
Member

@rustbot second

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label May 17, 2025
@apiraino
Copy link
Contributor

@rustbot label -final-comment-period +major-change-accepted

@rustbot rustbot added major-change-accepted A major change proposal that was accepted and removed final-comment-period The FCP has started, most (if not all) team members are in agreement labels May 29, 2025
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Development

No branches or pull requests

4 participants