use #[naked] as an unsafe attribute #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

tgross35 merged 1 commit into rust-lang:master from folkertdev:naked-unsafe-attribute

Apr 16, 2025

Contributor

folkertdev commented Apr 13, 2025

Per rust-lang/rust#134213 (comment), we want to make the #[naked] attribute an unsafe attribute.

Based on the CI failures here rust-lang/rust#139753, I believe that compiler-builtins need to be updated first.


          turn #[naked] into an unsafe attribute

fc301fb

folkertdev mentioned this pull request

Make #[naked] an unsafe attribute rust-lang/rust#139753

Merged

Contributor

tgross35 commented Apr 14, 2025 •

edited

Loading

Would it be possible for rustc to accept both forms until this gets updated, to bootstrap this? Unfortunately I don't know if we could merge and release this with the failures here.

Another case where a subtree would be nice...

Edit: I see rust-lang/rust#139797 now

Contributor Author

folkertdev commented Apr 14, 2025 •

edited

Loading

Right, yeah not ideal but we'll make it work. This PR will then likely needs some #[allow(unused-unsafe)]s for a bit too while we make this change, but we'll see when that PR makes it into a nightly build.

folkertdev closed this

folkertdev reopened this

Contributor Author

folkertdev commented Apr 16, 2025

Allright, this works now that rust-lang/rust#139797 is in nightly. After merging this, I guess the next step is to create a release of compiler-builtins, and then make rustc use that new release?

tgross35 approved these changes

View reviewed changes

Contributor

tgross35 left a comment •

edited

Loading

Thanks for the upstream changes, your description is correct. I'll sync it through today.

tgross35 merged commit 5b16250 into rust-lang:master

44 of 54 checks passed

tgross35 added a commit to tgross35/rust that referenced this pull request


          Update compiler-builtins to 0.1.154

a63c150

Includes the following changes:

* Replace `#[naked]` with `#[unsafe(naked)]` [1]

[1]: rust-lang/compiler-builtins#817

tgross35 mentioned this pull request

Update compiler-builtins to 0.1.155 rust-lang/rust#139934

Merged

tgross35 added a commit to tgross35/rust that referenced this pull request


          Update compiler-builtins to 0.1.155

7d6f41b

Includes the following changes:

* Replace `#[naked]` with `#[unsafe(naked)]` [1] [2]
* Replace `bl!` with `asm_sym` [3]

[1]: rust-lang/compiler-builtins#817
[2]: rust-lang/compiler-builtins#821
[3]: rust-lang/compiler-builtins#820

bors added a commit to rust-lang-ci/rust that referenced this pull request


          Auto merge of rust-lang#139934 - tgross35:update-builtins, r=<try>

Update `compiler-builtins` to 0.1.155

Includes the following changes:

* Replace `#[naked]` with `#[unsafe(naked)]` [1] [2]
* Replace `bl!` with `asm_sym` [3]

[1]: rust-lang/compiler-builtins#817
[2]: rust-lang/compiler-builtins#821
[3]: rust-lang/compiler-builtins#820

try-job: armhf-gnu
try-job: aarch64-apple
try-job: dist-apple-various

folkertdev pushed a commit to folkertdev/rust that referenced this pull request


          Update compiler-builtins to 0.1.155

8105bb3

Includes the following changes:

* Replace `#[naked]` with `#[unsafe(naked)]` [1] [2]
* Replace `bl!` with `asm_sym` [3]

[1]: rust-lang/compiler-builtins#817
[2]: rust-lang/compiler-builtins#821
[3]: rust-lang/compiler-builtins#820

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request


          Rollup merge of rust-lang#139934 - tgross35:update-builtins, r=tgross35

af61fdf

Update `compiler-builtins` to 0.1.155

Includes the following changes:

* Replace `#[naked]` with `#[unsafe(naked)]` [1] [2]
* Replace `bl!` with `asm_sym` [3]

[1]: rust-lang/compiler-builtins#817
[2]: rust-lang/compiler-builtins#821
[3]: rust-lang/compiler-builtins#820

try-job: armhf-gnu
try-job: aarch64-apple
try-job: dist-apple-various

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request


          Unrolled build for rust-lang#139934

Rollup merge of rust-lang#139934 - tgross35:update-builtins, r=tgross35

Update `compiler-builtins` to 0.1.155

Includes the following changes:

* Replace `#[naked]` with `#[unsafe(naked)]` [1] [2]
* Replace `bl!` with `asm_sym` [3]

[1]: rust-lang/compiler-builtins#817
[2]: rust-lang/compiler-builtins#821
[3]: rust-lang/compiler-builtins#820

try-job: armhf-gnu
try-job: aarch64-apple
try-job: dist-apple-various

traviscross mentioned this pull request

Stabilize naked_functions rust-lang/rust#134213

Merged

github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request


          Update compiler-builtins to 0.1.155

220a2e5

Includes the following changes:

* Replace `#[naked]` with `#[unsafe(naked)]` [1] [2]
* Replace `bl!` with `asm_sym` [3]

[1]: rust-lang/compiler-builtins#817
[2]: rust-lang/compiler-builtins#821
[3]: rust-lang/compiler-builtins#820

github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request


          Rollup merge of rust-lang#139934 - tgross35:update-builtins, r=tgross35

4b57af8

Update `compiler-builtins` to 0.1.155

Includes the following changes:

* Replace `#[naked]` with `#[unsafe(naked)]` [1] [2]
* Replace `bl!` with `asm_sym` [3]

[1]: rust-lang/compiler-builtins#817
[2]: rust-lang/compiler-builtins#821
[3]: rust-lang/compiler-builtins#820

try-job: armhf-gnu
try-job: aarch64-apple
try-job: dist-apple-various

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet