Skip to content

[WIP] Add an Inside Rust blog post for stage 0 std redesign #1582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented Apr 17, 2025

Tip

There are intentionally a lot of WIP intermediate commits for review purposes, I will rebase once the content is ready.

Accompanying blog post for:

r? @onur-ozkan (and @Mark-Simulacrum)
cc @rust-lang/bootstrap (significant stage 0 bootstrap changes)

Rendered

@jieyouxu
Copy link
Member Author

jieyouxu commented Apr 17, 2025

Hi @senekor, do you know what this zola failure is? Or am I missing sth in the front-matter?

Run zola build
Building site...
Checking all internal links with anchors.
> Successfully checked 254 internal link(s) with anchors.
-> Creating 600 pages (0 orphan) and 2 sections
Error: Failed to build the site
Error: Failed to render 'feed.xml'
Error: Reason: Filter call 'nth' failed
Error: Reason: Filter `nth` received an incorrect type for arg `n`: got `-2` but expected a usize
Error: Process completed with exit code 1.

I guess I'm missing a path = ""...? Or what am I supposed to put there?

@senekor
Copy link
Contributor

senekor commented Apr 17, 2025

Yes, the path key is required. The format has to be "YYYY/MM/DD/whatever-you-want".

I'll try to improve the templates so they produce better error messages in this case.

@senekor
Copy link
Contributor

senekor commented Apr 17, 2025

Oh if it's an inside-rust post, that should be in the path as well. So: "inside-rust/YYYY/MM/DD/whatever".

If the date of publication is not yet known, it's recommended to use the placeholder "9999/12/31" as the date, CI will prevent that from being published accidentally.

I can definitely improve docs/guidance/tooling/error msgs here.

@@ -0,0 +1,54 @@
+++
path = "inside-rust/9999/12/31/redesigning-stage-0-std"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIXME(jieyouxu): update this date when we're ready

Copy link
Member

@onur-ozkan onur-ozkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Just two suggestions in addition to my minor notes:

  1. It'd be helpful to mention the implementation PR.

  2. Consider showing the staging diagram to illustrate how things looked before and how they look now (the updated version is in the implementation PR).

@jieyouxu
Copy link
Member Author

It'd be helpful to mention the rust-lang/rust#119899.

I have no idea how I didn't include that when I even remember telling myself not to forget that lmao

@jieyouxu jieyouxu force-pushed the stage0-std-redesign branch from c8bc2d5 to 222f4fe Compare April 17, 2025 08:35
@jieyouxu
Copy link
Member Author

jieyouxu commented Apr 17, 2025

Changes since last review (in round 2 222f4fe):

  • Added a comparison diagram showing difference before/after the redesign.
  • Addressed nits.
  • Actually link to the stage 0 redesign PR itself.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: include pre/post CLI invocations and compare their behavioral differences.

Notably,

  • ./x build library --stage 0 (no-op in post) and ./x build library (0 pre, 1 post)
  • ./x build library --stage 0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: having someone on t-libs and someone on t-compiler skim it and sign off that it makes sense

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: move motivation section towards the end

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: create two dedicated bootstrap support threads (or just one?) and link to them from this blog post

  1. For general inqueries (why we're doing this?)
  2. For helping with issues and bugs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants