Skip to content

Commit c8d819a

Browse files
committed
[WIP] Address review comments (round 1)
1 parent b412814 commit c8d819a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Diff for: content/inside-rust/stage0-std-redesign.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ We are reworking how the stage 0 bootstrap sequence works (the sequence used to
1919
Notably, this means:
2020

2121
- `./x {build,test,check} library --stage 0` becomes no-op, as stage 0 std is no longer the built in-tree std, and the minimum supported stage to build std is now `1`.
22-
- Consequently, default (test, check, bench) stage values in the library profile are no longer `0`.
22+
- Consequently, default (test, check, bench) stage values in the library profile are no longer `0`, but instead defaults to `1`.
2323
- `cfg(bootstrap)` is no longer needed for library development. In (very) rare cases, `cfg(bootstrap)` may be needed in the compiler for dogfooding unstable library features.
2424

2525
## Motivation
@@ -31,7 +31,7 @@ This was [originally proposed by @jyn514 in the MCP rust-lang/compiler-team#619]
3131
## What does this mean for a typical library workflow?
3232

3333
- Crucially, `./x {build,test,check} library --stage 0` becomes no-op and are no longer supported. Building the in-tree std now requires a stage 1 compiler.
34-
- Consequently, library contributors are **strongly** encouraged to enable `rust.download-rustc = "if-unchanged"` to avoid having to build a stage 1 compiler.
34+
- Consequently, library contributors are *strongly* encouraged to enable `rust.download-rustc = "if-unchanged"` to avoid having to build a stage 1 compiler. Note that this is the default for `profile = "library"`, but you may need to specify it manually if you don't use a `profile`.
3535
- `cfg(bootstrap)` should no longer be needed for library sources.
3636

3737
### Caveat: `libtest` changes

0 commit comments

Comments
 (0)