Skip to content

Commit d020fcb

Browse files
Make pop function safer
But do we need to do this?
1 parent f23859d commit d020fcb

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

src/internal_queue.rs

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,12 @@ impl<T> SimpleQueue<T> {
3333
self.pos = 0;
3434
}
3535

36-
pub(crate) fn pop(&mut self) -> &T {
37-
self.pos += 1;
38-
&self.payload[self.pos - 1]
36+
pub(crate) fn pop(&mut self) -> Option<&T> {
37+
if self.pos < self.payload.len() {
38+
self.pos += 1;
39+
Some(&self.payload[self.pos - 1])
40+
} else {
41+
None
42+
}
3943
}
4044
}

0 commit comments

Comments
 (0)