Remove "Sort methods by trait definition" assist

It was replaced by the "Sort items by trait definition" assist.

Author: WaffleLapkin

crates/ide-assists/src/handlers/reorder_impl.rs

@@ -47,13 +47,6 @@ pub(crate) fn reorder_impl_items(acc: &mut Assists, ctx: &AssistContext) -> Opti
     let items = impl_ast.assoc_item_list()?;
     let assoc_items = items.assoc_items().collect::<Vec<_>>();
 
-    // If all items are either function or macro calls, then reorder_impl assist can be used
-    if assoc_items.iter().all(|i| matches!(i, ast::AssocItem::Fn(_) | ast::AssocItem::MacroCall(_)))
-    {
-        cov_mark::hit!(not_applicable_if_all_functions);
-        return None;
-    }
-
     let path = impl_ast
         .trait_()
         .and_then(|t| match t {
@@ -152,23 +145,41 @@ $0impl Bar for Foo {
     }
 
     #[test]
-    fn not_applicable_if_all_functions() {
-        cov_mark::check!(not_applicable_if_all_functions);
-        check_assist_not_applicable(
+    fn reorder_impl_trait_functions() {
+        check_assist(
             reorder_impl_items,
             r#"
 trait Bar {
     fn a() {}
-    fn z() {}
+    fn c() {}
     fn b() {}
+    fn d() {}
 }
+
 struct Foo;
 $0impl Bar for Foo {
+    fn d() {}
+    fn b() {}
+    fn c() {}
     fn a() {}
-    fn z() {}
+}
+"#,
+            r#"
+trait Bar {
+    fn a() {}
+    fn c() {}
     fn b() {}
+    fn d() {}
 }
-        "#,
+
+struct Foo;
+impl Bar for Foo {
+    fn a() {}
+    fn c() {}
+    fn b() {}
+    fn d() {}
+}
+"#,
         )
     }
 

crates/ide-assists/src/handlers/reorder_impl_items.rs

@@ -169,7 +169,6 @@ mod handlers {
     mod remove_mut;
     mod remove_unused_param;
     mod reorder_fields;
-    mod reorder_impl;
     mod reorder_impl_items;
     mod replace_try_expr_with_match;
     mod replace_derive_with_manual_impl;
@@ -257,7 +256,6 @@ mod handlers {
             remove_mut::remove_mut,
             remove_unused_param::remove_unused_param,
             reorder_fields::reorder_fields,
-            reorder_impl::reorder_impl,
             reorder_impl_items::reorder_impl_items,
             replace_try_expr_with_match::replace_try_expr_with_match,
             replace_derive_with_manual_impl::replace_derive_with_manual_impl,

crates/ide-assists/src/lib.rs

@@ -1736,41 +1736,6 @@ const test: Foo = Foo {foo: 1, bar: 0}
     )
 }
 
-#[test]
-fn doctest_reorder_impl() {
-    check_doc_test(
-        "reorder_impl",
-        r#####"
-trait Foo {
-    fn a() {}
-    fn b() {}
-    fn c() {}
-}
-
-struct Bar;
-$0impl Foo for Bar {
-    fn b() {}
-    fn c() {}
-    fn a() {}
-}
-"#####,
-        r#####"
-trait Foo {
-    fn a() {}
-    fn b() {}
-    fn c() {}
-}
-
-struct Bar;
-impl Foo for Bar {
-    fn a() {}
-    fn b() {}
-    fn c() {}
-}
-"#####,
-    )
-}
-
 #[test]
 fn doctest_reorder_impl_items() {
     check_doc_test(