Add a wishlist FIXME

scottmcm · web-flow · commit e300847864fa · 2023-10-06T07:05:09.000Z
diff --git a/tests/codegen/simd/simd-wide-sum.rs b/tests/codegen/simd/simd-wide-sum.rs
@@ -52,6 +52,8 @@ pub fn wider_reduce_iter(x: Simd<u8, N>) -> u16 {
 #[no_mangle]
 // CHECK-LABEL: @wider_reduce_into_iter
 pub fn wider_reduce_into_iter(x: Simd<u8, N>) -> u16 {
+    // FIXME: It would be nice if this was exactly the same as the above tests,
+    // but at the time of writing this comment, that didn't happen on LLVM main.
     // CHECK: call i16 @llvm.vector.reduce.add
     x.to_array().into_iter().map(u16::from).sum()
 }

Original file line number	Diff line number	Diff line change
`@@ -52,6 +52,8 @@ pub fn wider_reduce_iter(x: Simd<u8, N>) -> u16 {`
`52`	`52`	`#[no_mangle]`
`53`	`53`	`// CHECK-LABEL: @wider_reduce_into_iter`
`54`	`54`	`pub fn wider_reduce_into_iter(x: Simd<u8, N>) -> u16 {`
	`55`	`+ // FIXME: It would be nice if this was exactly the same as the above tests,`
	`56`	`+ // but at the time of writing this comment, that didn't happen on LLVM main.`
`55`	`57`	`// CHECK: call i16 @llvm.vector.reduce.add`
`56`	`58`	`x.to_array().into_iter().map(u16::from).sum()`
`57`	`59`	`}`