Skip to content

Commit aad709b

Browse files
committed
ci: Bring back ninja for dist builders
The primary reason for this is that make can result in a substantial under utilization of parallelism, mostly due to the submake structure preventing good dependency tracking and scheduling. In f758c7b (Debian 6 doesn't have ninja, so use make for the dist builds) llvm.ninja was disabled due to lack of distro package. This is no longer the case with the CentOS 7 base, so bring ninja back for a performance boost.
1 parent d7dd01f commit aad709b

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/ci/docker/host-x86_64/dist-i686-linux/Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ RUN yum upgrade -y && \
2323
libstdc++-devel.x86_64 \
2424
make \
2525
ncurses-devel \
26+
ninja-build \
2627
openssl-devel \
2728
patch \
2829
perl \
@@ -64,7 +65,6 @@ ENV RUST_CONFIGURE_ARGS \
6465
--enable-profiler \
6566
--set target.i686-unknown-linux-gnu.linker=clang \
6667
--build=i686-unknown-linux-gnu \
67-
--set llvm.ninja=false \
6868
--set rust.jemalloc
6969
ENV SCRIPT python3 ../x.py dist --build $HOSTS --host $HOSTS --target $HOSTS
7070
ENV CARGO_TARGET_I686_UNKNOWN_LINUX_GNU_LINKER=clang

src/ci/docker/host-x86_64/dist-x86_64-linux/Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ RUN yum upgrade -y && \
2323
libstdc++-devel.x86_64 \
2424
make \
2525
ncurses-devel \
26+
ninja-build \
2627
openssl-devel \
2728
patch \
2829
perl \
@@ -76,7 +77,6 @@ ENV RUST_CONFIGURE_ARGS \
7677
--set target.x86_64-unknown-linux-gnu.ar=/rustroot/bin/llvm-ar \
7778
--set target.x86_64-unknown-linux-gnu.ranlib=/rustroot/bin/llvm-ranlib \
7879
--set llvm.thin-lto=true \
79-
--set llvm.ninja=false \
8080
--set rust.jemalloc \
8181
--set rust.use-lld=true
8282
ENV SCRIPT ../src/ci/pgo.sh python3 ../x.py dist \

0 commit comments

Comments
 (0)