Skip to content

Commit a89f340

Browse files
committed
Nested job objects are now supported in CI
Nested job objects aren't supported on Windows 7 but we've long since moved on from that.
1 parent 01442e7 commit a89f340

File tree

1 file changed

+1
-9
lines changed

1 file changed

+1
-9
lines changed

src/bootstrap/src/utils/job.rs

+1-9
Original file line numberDiff line numberDiff line change
@@ -87,15 +87,7 @@ mod for_windows {
8787
);
8888
assert!(r.is_ok(), "{}", io::Error::last_os_error());
8989

90-
// Assign our process to this job object. Note that if this fails, one very
91-
// likely reason is that we are ourselves already in a job object! This can
92-
// happen on the build bots that we've got for Windows, or if just anyone
93-
// else is instrumenting the build. In this case we just bail out
94-
// immediately and assume that they take care of it.
95-
//
96-
// Also note that nested jobs (why this might fail) are supported in recent
97-
// versions of Windows, but the version of Windows that our bots are running
98-
// at least don't support nested job objects.
90+
// Assign our process to this job object.
9991
let r = AssignProcessToJobObject(job, GetCurrentProcess());
10092
if r.is_err() {
10193
CloseHandle(job).ok();

0 commit comments

Comments
 (0)