Skip to content

Commit a429afa

Browse files
camelidGuillaumeGomez
authored andcommitted
Remove RunnableDoctest
It should instead be the actual input to the running logic. Currently it's not actually quite runnable since it's still missing some information.
1 parent e9e2634 commit a429afa

File tree

1 file changed

+17
-24
lines changed

1 file changed

+17
-24
lines changed

src/librustdoc/doctest.rs

+17-24
Original file line numberDiff line numberDiff line change
@@ -1086,13 +1086,11 @@ impl CreateRunnableDoctests {
10861086
},
10871087
testfn: test::DynTestFn(Box::new(move || {
10881088
doctest_run_fn(
1089-
RunnableDoctest {
1090-
crate_name,
1091-
rustdoc_test_options,
1092-
opts,
1093-
path,
1094-
scraped_test: test,
1095-
},
1089+
crate_name,
1090+
rustdoc_test_options,
1091+
opts,
1092+
path,
1093+
test,
10961094
rustdoc_options,
10971095
unused_externs,
10981096
)
@@ -1101,36 +1099,31 @@ impl CreateRunnableDoctests {
11011099
}
11021100
}
11031101

1104-
/// A doctest that is ready to run.
1105-
struct RunnableDoctest {
1102+
fn doctest_run_fn(
11061103
crate_name: String,
1107-
rustdoc_test_options: IndividualTestOptions,
1108-
opts: GlobalTestOptions,
1104+
test_opts: IndividualTestOptions,
1105+
global_opts: GlobalTestOptions,
11091106
path: PathBuf,
11101107
scraped_test: ScrapedDoctest,
1111-
}
1112-
1113-
fn doctest_run_fn(
1114-
runnable_test: RunnableDoctest,
11151108
rustdoc_options: Arc<RustdocOptions>,
11161109
unused_externs: Arc<Mutex<Vec<UnusedExterns>>>,
11171110
) -> Result<(), String> {
11181111
let report_unused_externs = |uext| {
11191112
unused_externs.lock().unwrap().push(uext);
11201113
};
1121-
let no_run = runnable_test.scraped_test.no_run(&rustdoc_options);
1122-
let edition = runnable_test.scraped_test.edition(&rustdoc_options);
1114+
let no_run = scraped_test.no_run(&rustdoc_options);
1115+
let edition = scraped_test.edition(&rustdoc_options);
11231116
let res = run_test(
1124-
&runnable_test.scraped_test.text,
1125-
&runnable_test.crate_name,
1126-
runnable_test.scraped_test.line,
1117+
&scraped_test.text,
1118+
&crate_name,
1119+
scraped_test.line,
11271120
&rustdoc_options,
1128-
runnable_test.rustdoc_test_options,
1129-
runnable_test.scraped_test.langstr,
1121+
test_opts,
1122+
scraped_test.langstr,
11301123
no_run,
1131-
&runnable_test.opts,
1124+
&global_opts,
11321125
edition,
1133-
runnable_test.path,
1126+
path,
11341127
report_unused_externs,
11351128
);
11361129

0 commit comments

Comments
 (0)